From f3982671292dc3040814e40fcdde0af81fb22d0a Mon Sep 17 00:00:00 2001
From: Rolando Santamaria Maso <kyberneees@gmail.com>
Date: Sun, 31 May 2026 10:51:43 +0200
Subject: [PATCH] perf: cut query-string parsing cost on the request hot path
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

queryparams runs on every request. Two pieces of per-request work were
avoidable:

1. `search.replace(/\[\]=/g, '=')` ran a regex over every query string even
   when no `a[]=` array notation was present. Now gated on `indexOf('[]=')`.

2. `name.split(/[.[\]]+/).filter(Boolean)` allocated an array per parameter,
   every request, solely to guard against `__proto__`/`prototype`/`constructor`
   keys. The split now runs only for names containing `proto`/`constructor`
   (a superset of all dangerous keys), so normal params skip it entirely.

Behavior is identical — verified across repeated/array params and all
prototype-pollution key forms (new tests in router-coverage).

Measured (Node 22, 3M iters):
  typical  ?q=node&page=2&limit=20 : 489 -> 312 ns/op  (-36%)
  array    ?id[]=1&id[]=2&tag=x    : 595 -> 428 ns/op  (-28%)
  no-query /api/users             : 10.7 ns/op (unchanged)

Suite: 71 passing, queryparams.js at 100% line coverage.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 lib/utils/queryparams.js      | 25 ++++++++++++++++---------
 tests/router-coverage.test.js | 17 +++++++++++++++++
 2 files changed, 33 insertions(+), 9 deletions(-)

diff --git a/lib/utils/queryparams.js b/lib/utils/queryparams.js
index 14e6c9e..2ac4bc9 100644
--- a/lib/utils/queryparams.js
+++ b/lib/utils/queryparams.js
@@ -28,17 +28,24 @@ module.exports = (req, url) => {
     return
   }
 
-  // Process query parameters with optimized URLSearchParams handling
-  const searchParams = new URLSearchParams(search.replace(/\[\]=/g, '='))
+  // Only rewrite array notation (a[]=1 -> a=1) when it is actually present,
+  // avoiding a regex scan/allocation on the common query-string case.
+  const searchParams = new URLSearchParams(
+    search.indexOf('[]=') === -1 ? search : search.replace(/\[\]=/g, '=')
+  )
 
   for (const [name, value] of searchParams.entries()) {
-    // Split parameter name into segments by dot or bracket notation
-    /* eslint-disable-next-line */
-    const segments = name.split(/[\.\[\]]+/).filter(Boolean)
-
-    // Check each segment against the dangerous properties set
-    if (segments.some(segment => DANGEROUS_PROPERTIES.has(segment))) {
-      continue // Skip dangerous property names
+    // Prototype-pollution guard. The segment split/filter allocates per
+    // parameter, so it only runs for the rare names that could actually carry a
+    // dangerous segment. Every dangerous key ('__proto__', 'prototype',
+    // 'constructor') contains 'proto' or 'constructor' as a substring.
+    if (name.indexOf('proto') !== -1 || name.indexOf('constructor') !== -1) {
+      // Split parameter name into segments by dot or bracket notation
+      /* eslint-disable-next-line */
+      const segments = name.split(/[\.\[\]]+/).filter(Boolean)
+      if (segments.some(segment => DANGEROUS_PROPERTIES.has(segment))) {
+        continue // Skip dangerous property names
+      }
     }
 
     const existing = query[name]
diff --git a/tests/router-coverage.test.js b/tests/router-coverage.test.js
index 36f05c7..3869fa6 100644
--- a/tests/router-coverage.test.js
+++ b/tests/router-coverage.test.js
@@ -309,6 +309,23 @@ describe('0http - Router Coverage', () => {
       expect(req.path).to.equal('/path')
       expect(req.query).to.deep.equal({ param: '' })
     })
+
+    it('should group repeated and array-notation parameters', () => {
+      const req = {}
+      queryparams(req, '/path?id[]=1&id[]=2&name=a&name=b&tag=x')
+      expect(req.query).to.deep.equal({ id: ['1', '2'], name: ['a', 'b'], tag: 'x' })
+    })
+
+    it('should strip dangerous prototype-pollution keys', () => {
+      const req = {}
+      queryparams(req, '/path?__proto__=evil&prototype=z&user.constructor=bad&a[__proto__]=x&ok=1')
+      // Dangerous keys are dropped; the query object has no prototype.
+      expect(Object.getPrototypeOf(req.query)).to.equal(null)
+      expect(req.query.ok).to.equal('1')
+      expect(Object.keys(req.query)).to.deep.equal(['ok'])
+      // No pollution leaked onto Object.prototype.
+      expect(({}).evil).to.equal(undefined)
+    })
   })
 
   describe('Next Middleware Executor', () => {