Code quality

Author: PeterSurda

src/bitmessageqt/messagecompose.py

@@ -2,7 +2,7 @@
 Message editor with a wheel zoom functionality
 """
 
-from PyQt4 import QtCore, QtGui  # pylint disable:import-error
+from PyQt4 import QtCore, QtGui  # pylint disable=import-error
 
 
 class MessageCompose(QtGui.QTextEdit):

src/bitmessageqt/messageview.py

@@ -5,7 +5,7 @@
 
 """
 
-from PyQt4 import QtCore, QtGui
+from PyQt4 import QtCore, QtGui  # pylint: disable=import-error
 
 from safehtmlparser import SafeHTMLParser
 from tr import _translate

src/bitmessageqt/migrationwizard.py

@@ -1,5 +1,5 @@
 #!/usr/bin/env python2.7
-from PyQt4 import QtGui
+from PyQt4 import QtGui  # pylint: disable=import-error
 
 
 class MigrationWizardIntroPage(QtGui.QWizardPage):
@@ -21,7 +21,7 @@ def nextId(self):
 
 
 class MigrationWizardAddressesPage(QtGui.QWizardPage):
-    def __init__(self, addresses):
+    def __init__(self, addresses):  # pylint: disable=unused-argument
         super(QtGui.QWizardPage, self).__init__()
         self.setTitle("Addresses")
 

src/bitmessageqt/networkstatus.py

@@ -4,7 +4,7 @@
 
 import time
 
-from PyQt4 import QtCore, QtGui
+from PyQt4 import QtCore, QtGui  # pylint: disable=import-error
 
 import l10n
 import network.stats

src/bitmessageqt/retranslateui.py

@@ -1,4 +1,4 @@
-from PyQt4 import QtGui
+from PyQt4 import QtGui  # pylint: disable=import-error
 import widgets
 
 

src/bitmessageqt/settings.py

@@ -7,7 +7,7 @@
 import tempfile
 
 import six
-from PyQt4 import QtCore, QtGui
+from PyQt4 import QtCore, QtGui  # pylint: disable=import-error
 
 import debug
 import defaults

src/bitmessageqt/statusbar.py

@@ -2,7 +2,7 @@
 """Status bar Module"""
 
 from time import time
-from PyQt4 import QtGui
+from PyQt4 import QtGui  # pylint: disable=import-error
 
 
 class BMStatusBar(QtGui.QStatusBar):

src/bitmessageqt/support.py

@@ -6,7 +6,7 @@
 import sys
 import time
 
-from PyQt4 import QtCore
+from PyQt4 import QtCore  # pylint: disable=import-error
 
 import account
 import defaults
@@ -133,6 +133,7 @@ def createSupportMessage(myapp):
     architecture = "32" if ctypes.sizeof(ctypes.c_voidp) == 4 else "64"
     pythonversion = sys.version
 
+    # pylint: disable=protected-access
     opensslversion = "%s (Python internal), %s (external for PyElliptic)" % (
         ssl.OPENSSL_VERSION, OpenSSL._version)
 

src/bitmessageqt/uisignaler.py

@@ -1,5 +1,5 @@
 
-from PyQt4.QtCore import QThread, SIGNAL
+from PyQt4.QtCore import QThread, SIGNAL  # pylint: disable=import-error
 import sys
 
 import queues

src/bitmessageqt/utils.py

@@ -1,7 +1,7 @@
 import hashlib
 import os
 
-from PyQt4 import QtGui
+from PyQt4 import QtGui  # pylint: disable=import-error
 
 import state
 from addresses import addBMIfNotPresent
@@ -56,7 +56,7 @@ def identiconize(address):
     elif identicon_lib == 'pydenticon':
         # Here you could load pydenticon.py
         # (just put it in the "src" folder of your Bitmessage source)
-        from pydenticon import Pydenticon
+        from pydenticon import Pydenticon  # pylint: disable=import-error
         # It is not included in the source, because it is licensed under GPLv3
         # GPLv3 is a copyleft license that would influence our licensing
         # Find the source here:
@@ -65,7 +65,7 @@ def identiconize(address):
         # https://python-pillow.org/
         idcon_render = Pydenticon(
             addBMIfNotPresent(address) + identiconsuffix, size * 3)
-        rendering = idcon_render._render()
+        rendering = idcon_render._render()  # pylint: disable=protected-access
         data = rendering.convert("RGBA").tostring("raw", "RGBA")
         qim = QtGui.QImage(data, size, size, QtGui.QImage.Format_ARGB32)
         pix = QtGui.QPixmap.fromImage(qim)