Skip to content

Commit eb009cb

Browse files
authored
Merge pull request #12 from Breeding-Insight/bug/BI-2818
Fix NPE use cases when level name entities table is empty
2 parents 2a7d88c + a9ef485 commit eb009cb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/main/java/org/brapi/test/BrAPITestServer/service/pheno/ObservationUnitLevelNameService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public Map<String, ObservationUnitLevelNameEntity> verifyObservationUnitLevelNam
7676
.filter(ouln -> ouln.getLevelName().equals(sln.getLevelName()))
7777
.findFirst()
7878
.ifPresent(ouln -> verifiedEntitiesByLevelName.put(ouln.getLevelName(), ouln));
79-
} else if (StringUtils.isNotBlank(sln.getProgramDbId()) && StringUtils.isNotBlank(sln.getLevelName()) && foundLevelEntitiesGroupedByProgramId.get(parentProgramDbId) != null) {
79+
} else if (StringUtils.isNotBlank(sln.getProgramDbId()) && StringUtils.isNotBlank(sln.getLevelName()) && foundLevelEntitiesGroupedByProgramId.get(sln.getProgramDbId()) != null) {
8080
List<ObservationUnitLevelNameEntity> entities = foundLevelEntitiesGroupedByProgramId.get(sln.getProgramDbId());
8181

8282
entities.stream()
@@ -85,7 +85,7 @@ public Map<String, ObservationUnitLevelNameEntity> verifyObservationUnitLevelNam
8585
.ifPresent(ouln -> verifiedEntitiesByLevelName.put(ouln.getLevelName(), ouln));
8686
}
8787

88-
if (verifiedLevelNamesCurrentSize == verifiedEntitiesByLevelName.size()) {
88+
if (verifiedLevelNamesCurrentSize == verifiedEntitiesByLevelName.size() && foundLevelEntitiesGroupedByProgramId.get(GLOBAL_KEY_FOR_FOUND_ENTITIES) != null) {
8989
// All other ways of detecting the level name have failed so far, try the global ones as a last-ditch effort
9090
List<ObservationUnitLevelNameEntity> globalEntities = foundLevelEntitiesGroupedByProgramId.get(GLOBAL_KEY_FOR_FOUND_ENTITIES);
9191

0 commit comments

Comments
 (0)