Address PR review: clearer count tests, empty string case, simplify ordinal logic

Author: salahalsabhi

practice-tdd/count.test.js

@@ -23,7 +23,7 @@ test("should count multiple occurrences of a character", () => {
 // When the function is called with these inputs,
 // Then it should return 0, indicating that no occurrences of `char` were found.
 
-test("should count multiple occurrences of a character including upper cases", () => {
+test("should count character occurrences case-insensitively", () => {
   const str = "BanaNa";
   const char = "n";
   const count = countChar(str, char);
@@ -36,3 +36,7 @@ test("should count 0 occurrences of a character", () => {
   const count = countChar(str, char);
   expect(count).toEqual(0);
 });
+
+test("should return 0 when the string is empty", () => {
+  expect(countChar("", "a")).toEqual(0);
+});

practice-tdd/get-ordinal-number.js

@@ -1,11 +1,24 @@
 export function getOrdinalNumber(num) {
-  return num % 100 === 11 || num % 100 === 12 || num % 100 === 13
-    ? `${num}th`
-    : num % 10 === 1
-      ? `${num}st`
-      : num % 10 === 2
-        ? `${num}nd`
-        : num % 10 === 3
-          ? `${num}rd`
-          : `${num}th`;
+  const lastTwoDigits = num % 100;
+  const lastDigit = num % 10;
+
+  if (lastTwoDigits === 11 || lastTwoDigits === 12 || lastTwoDigits === 13) {
+    return `${num}th`;
+  }
+
+  if (lastDigit === 1) {
+    return `${num}st`;
+  }
+
+  if (lastDigit === 2) {
+    return `${num}nd`;
+  }
+
+  if (lastDigit === 3) {
+    return `${num}rd`;
+  }
+
+  return `${num}th`;
 }
+
+

practice-tdd/get-ordinal-number.test.js

@@ -37,7 +37,7 @@ test("should append 'th' for numbers ending with 11, 12, or 13.", () => {
   expect(getOrdinalNumber(13)).toEqual("13th");
 });
 
-test("should append 'th' for numbers ending with 0, 4, or big numbers.", () => {
+test("should append 'th' for numbers ending in 0 or 4–9", () => {
   expect(getOrdinalNumber(10)).toEqual("10th");
   expect(getOrdinalNumber(30)).toEqual("30th");
   expect(getOrdinalNumber(500)).toEqual("500th");