Skip to content

Commit 7364607

Browse files
correct exercises@
1 parent 837121a commit 7364607

2 files changed

Lines changed: 12 additions & 21 deletions

File tree

‎implement-and-rewrite-tests/implement/3-get-card-value.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ export function getCardValue(card) {
4141
}
4242

4343
return Number(rank);
44-
}
44+
}

‎implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js‎

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -9,43 +9,34 @@ test("decimal numerator should return false", () => {
99
expect(isProperFraction(0.5, 2)).toBe(false);
1010
});
1111

12-
test("zero numerator", () => {
12+
test("zero numerator should return true", () => {
1313
expect(isProperFraction(0, 5)).toBe(true);
1414
});
1515

16-
test("numerator bigger than denominator", () => {
16+
test("numerator bigger then denominator should return false", () => {
1717
expect(isProperFraction(20, 15)).toBe(false);
1818
});
1919

20-
test("zero denominator", () => {
21-
expect(isProperFraction(100, 0)).toBe(false);
22-
});
23-
24-
test("equal numerator and denominator", () => {
20+
test("equal numerator and denominator should return false", () => {
2521
expect(isProperFraction(3, 3)).toBe(false);
2622
});
2723

2824
test("should return false when denominator is zero", () => {
29-
expect(isProperFraction(1, 0)).toBe(false);
25+
expect(isProperFraction(100, 0)).toBe(false);
3026
});
3127

32-
test("decimal numerator should return false", () => {
33-
expect(isProperFraction(0.5, 2)).toBe(false);
28+
test("negative numeratore smaller then a positive denumerator should return true", () => {
29+
expect(isProperFraction(-5, 16)).toBe(true);
3430
});
3531

36-
test("zero numerator", () => {
37-
expect(isProperFraction(0, 5)).toBe(true);
32+
test("positive numeratior and negative denumerator should return false", () => {
33+
expect(isProperFraction(5, -16)).toBe(false);
3834
});
3935

40-
test("numerator bigger than denominator", () => {
36+
test("negative numerator smaller than a negative denominator should return false", () => {
4137
expect(isProperFraction(20, 15)).toBe(false);
4238
});
4339

44-
test("zero denominator should fail", () => {
45-
expect(isProperFraction(100, 0)).toBe(false);
46-
});
47-
48-
test("negative numerator should pass", () => {
49-
expect(isProperFraction(-75, 100)).toBe(true);
40+
test("negative numerator bigger than a negative denominator should return false", () => {
41+
expect(isProperFraction(-16, -50)).toBe(false);
5042
});
51-

0 commit comments

Comments
 (0)