improved time validation and formatting logic

Author: AkliluMihtsun

format-clock-edge-cases/timeConverter.js

@@ -1,18 +1,29 @@
 function formatAs12HourClock(time) {
-  const hours = Number(time.slice(0, 2));
+  const slicedHours = time.slice(0, 2);
+  const hours = Number(slicedHours);
   const slicedMinutes = time.slice(-2);
+  const minutes = Number(slicedMinutes);
+  const pattern = /^\d{2}:\d{2}$/;
 
-  if (hours === 0) {
-    return `12:${slicedMinutes} am`;
-  } else if (hours > 1 && hours <= 11) {
-    return `0${hours}:${slicedMinutes} am`;
-  } else if (hours === 12) {
-    return `12:${slicedMinutes} pm`;
-  } else if (hours > 12 && hours <= 21) {
-    return `0${hours - 12}:${slicedMinutes} pm`;
-  } else if (hours === 22 || hours === 23) {
-    return `${hours - 12}:${slicedMinutes} pm`;
+  if (typeof time === "string" && pattern.test(time)) {
+    if (minutes < 60) {
+      if (hours < 24) {
+        if (hours === 0) {
+          return `12:${slicedMinutes} am`;
+        } else if (hours === 12) {
+          return `${hours}:${slicedMinutes} pm`;
+        } else if (hours > 12) {
+          return `${(hours - 12).toString().padStart(2, "0")}:${slicedMinutes} pm`;
+        } else {
+          return `${time} am`;
+        }
+      }
+
+      return `Please check your HH input must be less than 24`;
+    }
+    return `Please check your MM input must be less than 60`;
   }
+  return `Please check your format input must be 'HH:MM'`;
 }
 
 export { formatAs12HourClock };