Skip to content

Commit 92ada3e

Browse files
adding more test cases for missing values and lowercase letters
1 parent f0d59ee commit 92ada3e

1 file changed

Lines changed: 13 additions & 10 deletions

File tree

‎implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js‎

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@ test("Valid single-digit card", () => {
1010
});
1111

1212
test("Arbitrary non-card string", () => {
13-
assert.throws(() => getCardValue("invalid"), /Expected a number followed by a suit, but got "invalid"/, "Expected clear error");
13+
assert.throws(
14+
() => getCardValue("invalid"),
15+
/Expected a number followed by a suit, but got "invalid"/,
16+
"Expected clear error"
17+
);
1418
});
1519

1620
// TODO: What other invalid card cases can you think of?
@@ -30,19 +34,18 @@ test("Face cards return 10", () => {
3034
assert.equal(getCardValue("K♥"), 10);
3135
});
3236

33-
test("Invalid rank throws an error", () => {
37+
test("Invalid format throws an error", () => {
38+
assert.throws(() => getCardValue("A★"), Error);
3439
assert.throws(() => getCardValue("11♠"), Error);
3540
assert.throws(() => getCardValue("X♥"), Error);
36-
});
37-
38-
test("Invalid suit throws an error", () => {
39-
assert.throws(() => getCardValue("A★"), Error);
40-
});
41-
42-
test("Invalid format throws an error", () => {
4341
assert.throws(() => getCardValue("A"), Error);
4442
assert.throws(() => getCardValue("♠A"), Error);
4543
assert.throws(() => getCardValue(" A♠"), Error);
4644
assert.throws(() => getCardValue("A♠♠"), Error);
45+
assert.throws(() => getCardValue(undefined), Error);
46+
assert.throws(() => getCardValue(null), Error);
47+
assert.throws(() => getCardValue(""), Error);
48+
assert.throws(() => getCardValue("a♠"), Error);
49+
assert.throws(() => getCardValue("k♥"), Error);
50+
assert.throws(() => getCardValue("q♦"), Error);
4751
});
48-

0 commit comments

Comments
 (0)