Skip to content

Commit a806e26

Browse files
improve isProperFraction test descriptions
1 parent a734d05 commit a806e26

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

‎implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,43 +7,43 @@ test(`should return false when denominator is zero`, () => {
77
expect(isProperFraction(1, 0)).toEqual(false);
88
});
99

10-
test(`should return true when numerator is smaller than denominator `, () => {
10+
test(`should return true when |numerator| < |denominator|`, () => {
1111
expect(isProperFraction(3, 5)).toEqual(true);
1212
});
1313

14-
test(`should return false when numerator is bigger than denominator `, () => {
14+
test(`should return false when |numerator| > |denominator| `, () => {
1515
expect(isProperFraction(6, 2)).toEqual(false);
1616
});
1717

18-
test(`should return true when numerator is zero`, () => {
18+
test(`should return true when numerator is zero and denominator is non-zero`, () => {
1919
expect(isProperFraction(0, 2)).toEqual(true);
2020
});
2121

22-
test(`should return true when numerator is negative ans smaller`, () => {
22+
test(`should return true when numerator is negative and |numerator| < |denominator|`, () => {
2323
expect(isProperFraction(-4, 6)).toEqual(true);
2424
});
2525

26-
test(`should return false when numerator is negative ans bigger`, () => {
26+
test(`should return false when numerator is negative and |numerator| > |denominator|`, () => {
2727
expect(isProperFraction(-8, 6)).toEqual(false);
2828
});
2929

30-
test(`should return true when denominator is negative and bigger`, () => {
30+
test(`should return true when denominator is negative and |numerator| < |denominator|`, () => {
3131
expect(isProperFraction(2, -5)).toEqual(true);
3232
});
3333

34-
test(`should return false when denominator is negative ans smaller`, () => {
34+
test(`should return false when denominator is negative and |numerator| > |denominator|`, () => {
3535
expect(isProperFraction(4, -3)).toEqual(false);
3636
});
3737

38-
test(`should return correct answer when both is negative`, () => {
38+
test(`should compare absolute values when both numbers are negative`, () => {
3939
expect(isProperFraction(-4, -3)).toEqual(false);
4040
expect(isProperFraction(-1, -3)).toEqual(true);
4141
});
4242

43-
test(`should return true answer when Zero numerator and negative denominator`, () => {
43+
test(` should return true when numerator is zero and denominator is negative`, () => {
4444
expect(isProperFraction(0, -3)).toEqual(true);
4545
});
4646

47-
test(`should return false when both are zero`, () => {
47+
test(`should return false when numerator and denominator are both zero`, () => {
4848
expect(isProperFraction(0, 0)).toEqual(false);
4949
});

0 commit comments

Comments
 (0)