Fix proper fraction logic and tests

Author: fatimarouchi

implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -14,5 +14,5 @@
 // execute the code to ensure all tests pass.
 
 export function isProperFraction(numerator, denominator) {
-  return numerator < denominator;
+  return Math.abs(numerator) < Math.abs(denominator);
 }

implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -1,25 +1,27 @@
 import { isProperFraction } from "../implement/2-is-proper-fraction.js";
 
-// TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
-
-// Special case: numerator is zero
-test(`should return false when denominator is zero`, () => {
+test("should return false when the denominator is zero", () => {
   expect(isProperFraction(1, 0)).toEqual(false);
+  expect(isProperFraction(0, 0)).toEqual(false);
 });
+
 test("should return true for a proper fraction", () => {
   expect(isProperFraction(1, 2)).toEqual(true);
 });
 
-test("should return false when numerator equals denominator", () => {
+test("should return false when the numerator and denominator have equal magnitudes", () => {
   expect(isProperFraction(5, 5)).toEqual(false);
+  expect(isProperFraction(-5, -5)).toEqual(false);
 });
 
-test("should return false when numerator is greater than denominator", () => {
+test("should return false when the numerator's magnitude exceeds the denominator's", () => {
   expect(isProperFraction(7, 3)).toEqual(false);
+  expect(isProperFraction(-7, 3)).toEqual(false);
 });
 
 test("should return true when numerator is zero", () => {
   expect(isProperFraction(0, 5)).toEqual(true);
+  expect(isProperFraction(0, -5)).toEqual(true);
 });
 
 test("should return true when both numerator and denominator are negative and form a proper fraction", () => {
@@ -30,6 +32,10 @@ test("should return true for negative numerator and positive denominator", () =>
   expect(isProperFraction(-1, 2)).toEqual(true);
 });
 
-test("should return false for positive numerator and negative denominator", () => {
-  expect(isProperFraction(1, -2)).toEqual(false);
+test("should return true for positive numerator and negative denominator when the numerator is smaller", () => {
+  expect(isProperFraction(1, -2)).toEqual(true);
+});
+
+test("should return false for negative numerator and positive denominator when the numerator is larger", () => {
+  expect(isProperFraction(-3, 2)).toEqual(false);
 });