revise function and test for getAngleType

Author: leerogerfn

implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js

@@ -26,6 +26,11 @@ test("Classifies reflex angle", () => {
 });
 
 test("Classifies boundary and invalid angles", () => {
-  assert.equal(getAngleType(365), "Invalid angle");
-  assert.equal(getAngleType(-10), "Invalid angle");
+  assert.equal(getAngleType(365), "invalid angle");
+  assert.equal(getAngleType(-10), "invalid angle");
+  assert.equal(getAngleType(0), "invalid angle");
+  assert.equal(getAngleType(""), "invalid angle");
+  assert.equal(getAngleType("angle"), "invalid angle");
+  assert.equal(getAngleType("null"), "invalid angle")
+
 });

implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -17,7 +17,10 @@
 // execute the code to ensure all tests pass.
 
 function getAngleType(angle) {
-  if (angle > 180 && angle < 360) {
+  if (angle > 360 || angle  <= 0 || angle === "" || isNaN(angle)) {
+    return "invalid angle"
+  }
+    else if (angle > 180 && angle < 360) {
     return "Reflex angle";
   } else if (angle === 180) {
     return "Straight angle";
@@ -28,7 +31,7 @@ function getAngleType(angle) {
   } else if (angle < 90 && angle > 0) {
     return "Acute angle";
   }
-  return "Invalid angle";
+  
 }
 
 export { getAngleType };

implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -34,7 +34,10 @@ test(`should return "Reflex angle" when (angle > 180 && angle < 360)`, () => {
 });
 
 // Case 6: Invalid angles
-test(`should return "Invalid angle" when (angel > 360 || angle < 1)`, () => {
-  expect(getAngleType(-10)).toEqual("Invalid angle");
-  expect(getAngleType(365)).toEqual("Invalid angle");
+test(`should return "Invalid value" when (angel > 360 || angle <= 0 || angel = "")`, () => {
+  expect(getAngleType(-10)).toEqual("invalid angle");
+  expect(getAngleType(365)).toEqual("invalid angle");
+  expect(getAngleType()).toEqual("invalid angle");
+  expect(getAngleType(null)).toEqual("invalid angle");
+  expect(getAngleType("angle")).toEqual("invalid angle");
 });