revised function and test for getAngleType.

Author: leerogerfn

implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js

@@ -31,6 +31,11 @@ test("Classifies boundary and invalid angles", () => {
   assert.equal(getAngleType(0), "invalid angle");
   assert.equal(getAngleType(""), "invalid angle");
   assert.equal(getAngleType("angle"), "invalid angle");
-  assert.equal(getAngleType("null"), "invalid angle")
-
+  assert.equal(getAngleType("null"), "invalid angle");
+  assert.equal(getAngleType(360), "invalid angle");
+  assert.equal(getAngleType(181), "Reflex angle");
+  assert.equal(getAngleType(91), "Obtuse angle");
+  assert.equal(getAngleType(179), "Obtuse angle");
+  assert.equal(getAngleType(89), "Acute angle");
+  assert.equal(getAngleType(1), "Acute angle");
 });

implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -17,10 +17,9 @@
 // execute the code to ensure all tests pass.
 
 function getAngleType(angle) {
-  if (angle > 360 || angle  <= 0 || angle === "" || isNaN(angle)) {
-    return "invalid angle"
-  }
-    else if (angle > 180 && angle < 360) {
+  if (angle >= 360 || angle <= 0 || angle === "" || isNaN(angle)) {
+    return "invalid angle";
+  } else if (angle > 180 && angle < 360) {
     return "Reflex angle";
   } else if (angle === 180) {
     return "Straight angle";
@@ -31,7 +30,6 @@ function getAngleType(angle) {
   } else if (angle < 90 && angle > 0) {
     return "Acute angle";
   }
-  
 }
 
 export { getAngleType };

implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -18,9 +18,9 @@ test(`should return "Right angle" when (angle === 90)`, () => {
 
 // Case 3: Obtuse angles
 test(`should return "Obtuse angle" when (angle < 180 && angle > 90)`, () => {
-  expect(getAngleType(100)).toEqual("Obtuse angle");
+  expect(getAngleType(91)).toEqual("Obtuse angle");
   expect(getAngleType(120)).toEqual("Obtuse angle");
-  expect(getAngleType(175)).toEqual("Obtuse angle");
+  expect(getAngleType(179)).toEqual("Obtuse angle");
 });
 
 // Case 4: Straight angle
@@ -30,13 +30,17 @@ test(`should return "Straight angle" when (angle === 180)`, () => {
 
 // Case 5: Reflex angles
 test(`should return "Reflex angle" when (angle > 180 && angle < 360)`, () => {
+  expect(getAngleType(181)).toEqual("Reflex angle");
   expect(getAngleType(190)).toEqual("Reflex angle");
+  expect(getAngleType(359)).toEqual("Reflex angle");
 });
 
 // Case 6: Invalid angles
-test(`should return "Invalid value" when (angel > 360 || angle <= 0 || angel = "")`, () => {
+test(`should return "Invalid value" when (angel >= 360 || angle <= 0 || angel = "")`, () => {
   expect(getAngleType(-10)).toEqual("invalid angle");
   expect(getAngleType(365)).toEqual("invalid angle");
+  expect(getAngleType(360)).toEqual("invalid angle");
+  expect(getAngleType(0)).toEqual("invalid angle");
   expect(getAngleType()).toEqual("invalid angle");
   expect(getAngleType(null)).toEqual("invalid angle");
   expect(getAngleType("angle")).toEqual("invalid angle");