Skip to content

Commit 94aa1f1

Browse files
committed
ci(template): pin actions by SHA and declare permissions like the satellites
The template workflows used tag pins, validate-data had no permissions block and carried a comment about game-catalog's record count. They now take the form game-catalog runs: the same pinned SHAs, read-only permissions, concurrency and timeouts.
1 parent 8362da8 commit 94aa1f1

2 files changed

Lines changed: 17 additions & 7 deletions

File tree

‎machine/satellite_template/.github/workflows/deploy-pages.yml‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,24 +19,25 @@ jobs:
1919
runs-on: ubuntu-latest
2020
timeout-minutes: 60
2121
steps:
22-
- uses: actions/checkout@v4
22+
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
2323
with:
2424
fetch-depth: 0 # history.json replays every data commit
25-
- uses: actions/setup-python@v5
25+
- uses: actions/setup-python@6d4fd22b20465ccc0f7354476588e8df7c9ca0e0 # v7.1.0
2626
with:
2727
python-version: "3.12"
2828
- name: Build summary + history
2929
run: python site/build.py
30-
- uses: actions/upload-pages-artifact@v3
30+
- uses: actions/upload-pages-artifact@fc324d3547104276b827a68afc52ff2a11cc49c9 # v5.0.0
3131
with:
3232
path: site
3333

3434
deploy:
3535
needs: build
3636
runs-on: ubuntu-latest
37+
timeout-minutes: 10
3738
environment:
3839
name: github-pages
3940
url: ${{ steps.deployment.outputs.page_url }}
4041
steps:
4142
- id: deployment
42-
uses: actions/deploy-pages@v4
43+
uses: actions/deploy-pages@368f82528645a54fb793d4d04e342629a3f51346 # v5.0.1

‎machine/satellite_template/.github/workflows/validate-data.yml‎

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,26 @@
11
name: validate-data
22

3+
# GITHUB_TOKEN only: no personal access tokens, no bot account, no writes.
34
on:
45
pull_request:
56
push:
67
branches: [develop, main]
78

9+
permissions:
10+
contents: read
11+
12+
concurrency:
13+
group: validate-data-${{ github.ref }}
14+
cancel-in-progress: true
15+
816
jobs:
917
validate:
1018
runs-on: ubuntu-latest
11-
timeout-minutes: 90 # 962k files; measure a real run before trimming
19+
# Generous for a new catalog; measure a real run before trimming.
20+
timeout-minutes: 30
1221
steps:
13-
- uses: actions/checkout@v4
14-
- uses: actions/setup-python@v5
22+
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
23+
- uses: actions/setup-python@6d4fd22b20465ccc0f7354476588e8df7c9ca0e0 # v7.1.0
1524
with:
1625
python-version: "3.12"
1726
- name: Validate {{title}}

0 commit comments

Comments
 (0)