Skip to content

Commit ec05219

Browse files
committed
add changelog entries, provider gtest and include cleanups
1 parent 14e21c5 commit ec05219

4 files changed

Lines changed: 14 additions & 3 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111
* Added `add_event` and `add_cleanup_event` methods and `cleanup_events` and `num_cleanup_events` properties to the order manager, for tracking the events that gate the release of objects used by offloaded tasks [gh-2359](https://github.com/IntelPython/dpctl/pull/2359)
1212
* Added `SyclQueue_DeferRelease` C-API function, which defers a release callback until work submitted to a queue completes, and through which `dpctl::utils::keep_args_alive` keeps its arguments alive [gh-2359](https://github.com/IntelPython/dpctl/pull/2359)
1313
* Added `dpctl::utils::defer_release` to `dpctl4pybind11.hpp`, which calls a release callback once the given events have completed [gh-2359](https://github.com/IntelPython/dpctl/pull/2359)
14+
* Added support for building `dpctl` with AdaptiveCpp as the SYCL implementation, selected with `--sycl-provider=AdaptiveCpp` in `scripts/build_locally.py` or `-DDPCTL_SYCL_PROVIDER=AdaptiveCpp` [gh-2384](https://github.com/IntelPython/dpctl/pull/2384)
15+
* Added `dpctl.backend_type.openmp` for the AdaptiveCpp OpenMP host device [gh-2384](https://github.com/IntelPython/dpctl/pull/2384)
16+
* Added `DPCTLService_GetSyclProvider` C-API function and `dpctl._diagnostics.sycl_provider`, which report the SYCL implementation `dpctl` was built with [gh-2384](https://github.com/IntelPython/dpctl/pull/2384)
1417

1518
### Changed
1619
* Object lifetime during offload is now managed by a list of releases deferred until the events that gate them have completed, rather than by a `host_task`. `dpctl` keeps one thread for looking over the list and running the releases that have come due, started by the first release deferred and again in the child of a `fork`, which takes the GIL to do so and lets a release call into the interpreter and free USM allocations [gh-2359](https://github.com/IntelPython/dpctl/pull/2359)
@@ -25,6 +28,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2528
* Removed the deprecated `dpctl.program` submodule, use `dpctl.compiler` instead [gh-2407](https://github.com/IntelPython/dpctl/pull/2407)
2629

2730
### Fixed
31+
* `dpctl.select_device_with_aspects` no longer raises `SyclDeviceCreationError` when every device with the required aspects has a selector score of zero [gh-2384](https://github.com/IntelPython/dpctl/pull/2384)
2832
* Removed stale `select_host_device` and `has_host_device` names from `dpctl.__all__`, which made `from dpctl import *` fail with `AttributeError` [gh-2410](https://github.com/IntelPython/dpctl/pull/2410)
2933
* A USM allocation that fails now drops the references held for offloaded tasks that have completed, and is attempted once more if that released anything, so that memory only waiting to be given up is not reported as unavailable [gh-2359](https://github.com/IntelPython/dpctl/pull/2359)
3034

‎libsyclinterface/include/syclinterface/dpctl_sycl_type_casters.hpp‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ DEFINE_SIMPLE_CONVERSION_FUNCTIONS(
7171
DPCTLSyclKernelBundleRef)
7272
#endif
7373

74-
#include "dpctl_sycl_device_manager.h"
75-
7674
#include "dpctl_sycl_device_manager.h"
7775
DEFINE_SIMPLE_CONVERSION_FUNCTIONS(std::vector<DPCTLSyclDeviceRef>,
7876
DPCTLDeviceVectorRef)

‎libsyclinterface/source/dpctl_sycl_kernel_bundle_interface.cpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
#include "dpctl_error_handlers.h"
3636
#include "dpctl_sycl_kernel_bundle_interface.h"
3737
#include "dpctl_sycl_type_casters.hpp"
38-
#include <CL/cl.h> /* OpenCL headers */
3938
#include <cstdint>
4039
#include <sstream>
4140
#include <stddef.h>

‎libsyclinterface/tests/test_service.cpp‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
#include "Config/dpctl_config.h"
2828
#include "dpctl_service.h"
29+
#include "dpctl_utils.h"
2930
#include <gtest/gtest.h>
3031
#include <string>
3132

@@ -46,3 +47,12 @@ TEST(TestServicesFns, ChkDPCPPVersion)
4647
// from compiler
4748
ASSERT_TRUE(found != std::string::npos);
4849
}
50+
51+
TEST(TestServicesFns, ChkSyclProvider)
52+
{
53+
auto c_prov = DPCTLService_GetSyclProvider();
54+
std::string prov = std::string(c_prov);
55+
DPCTLCString_Delete(c_prov);
56+
57+
ASSERT_TRUE(prov == "Intel" || prov == "AdaptiveCpp");
58+
}

0 commit comments

Comments
 (0)