From 2d02d914d8d707fa2573e5a5e68587b002dd78ec Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Tue, 17 Nov 2026 12:40:13 +0000 Subject: [PATCH 1/5] test: verify cropper owns uploaded signature selection size Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> --- src/tests/components/Draw/FileUpload.spec.ts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/tests/components/Draw/FileUpload.spec.ts b/src/tests/components/Draw/FileUpload.spec.ts index de01f9d014..4b78fcbfc5 100644 --- a/src/tests/components/Draw/FileUpload.spec.ts +++ b/src/tests/components/Draw/FileUpload.spec.ts @@ -102,6 +102,18 @@ describe('FileUpload.vue - Uploaded signature flow', () => { expect(wrapper.vm.defaultStencilSize).toEqual({ width: 350, height: 100 }) }) + it('delegates initial crop selection size to the cropper', async () => { + const wrapper = mountComponent() + + wrapper.vm.image = 'data:image/png;base64,uploaded' + await wrapper.vm.$nextTick() + + const cropper = wrapper.findComponent({ name: 'Cropper' }) + expect(cropper.exists()).toBe(true) + expect(cropper.props('defaultSize')).toBeUndefined() + expect(cropper.props('stencilProps')).toEqual({ aspectRatio: 3.5 }) + }) + it('loads the selected file as a data URL', () => { const wrapper = mountComponent() const listeners = new Map void>>() From 5683304f1b61f4cf4581cfee98ff2da8df77e109 Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Tue, 17 Nov 2026 12:47:06 +0000 Subject: [PATCH 2/5] fix: restore cropper default selection for uploaded signatures Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> --- src/components/Draw/FileUpload.vue | 81 ++------------------ src/tests/components/Draw/FileUpload.spec.ts | 24 +----- 2 files changed, 10 insertions(+), 95 deletions(-) diff --git a/src/components/Draw/FileUpload.vue b/src/components/Draw/FileUpload.vue index 3863f2075e..ae2b3bcc39 100644 --- a/src/components/Draw/FileUpload.vue +++ b/src/components/Draw/FileUpload.vue @@ -18,10 +18,9 @@ @change="fileSelect"> -
+
@@ -110,7 +109,7 @@ import { mdiMagnifyMinusOutline, mdiMagnifyPlusOutline, } from '@mdi/js' -import { computed, nextTick, onBeforeUnmount, onMounted, ref, watch } from 'vue' +import { computed, nextTick, ref, watch } from 'vue' import { Cropper } from 'vue-advanced-cropper' import { getCapabilities } from '@nextcloud/capabilities' @@ -145,11 +144,6 @@ type CropperInstance = { getResult?: () => CropperResult } -type ResizeObserverLike = { - disconnect: () => void - observe: (target: Element) => void -} - defineOptions({ name: 'FileUpload', }) @@ -180,13 +174,10 @@ const confirmSignatureDialogTitle = t('libresign', 'Confirm your signature') const file = ref(null) const cropper = ref(null) -const cropperContainer = ref(null) -const resizeObserver = ref(null) const modal = ref(false) const image = ref('') const imageData = ref('') -const containerWidth = ref(0) const pendingFitCenter = ref(false) const zoomLevel = ref(1) const zoomMin = 0.1 @@ -219,37 +210,6 @@ const stencilProps = computed(() => ({ aspectRatio: stencilAspectRatio.value, })) -const defaultStencilSize = computed(() => { - if (!containerWidth.value) { - return { - width: stencilBaseWidth, - height: stencilBaseHeight, - } - } - const availableWidth = Math.max(0, containerWidth.value - 24) - const scale = Math.min(1, availableWidth / stencilBaseWidth) - return { - width: Math.floor(stencilBaseWidth * scale), - height: Math.floor(stencilBaseHeight * scale), - } -}) - -function initResizeObserver() { - if (!window.ResizeObserver || !cropperContainer.value) { - return - } - if (!resizeObserver.value) { - resizeObserver.value = new window.ResizeObserver(() => updateContainerWidth()) as ResizeObserverLike - } else { - resizeObserver.value.disconnect() - } - resizeObserver.value.observe(cropperContainer.value) -} - -function updateContainerWidth() { - containerWidth.value = cropperContainer.value?.offsetWidth || 0 -} - function updateZoomLevel(result?: CropperResult) { if (result) { updateZoomLevelFromResult(result) @@ -387,35 +347,12 @@ function close() { emit('close') } -onMounted(() => { - updateContainerWidth() - if (window.ResizeObserver) { - void nextTick(() => { - initResizeObserver() - }) - } else { - window.addEventListener('resize', updateContainerWidth) - } -}) - -onBeforeUnmount(() => { - resizeObserver.value?.disconnect() - window.removeEventListener('resize', updateContainerWidth) -}) - watch(hasImage, value => { - if (value) { - void nextTick(() => { - updateContainerWidth() - initResizeObserver() - }) - return + if (!value) { + zoomLevel.value = 1 + pendingFitCenter.value = false + imageData.value = '' } - resizeObserver.value?.disconnect() - containerWidth.value = 0 - zoomLevel.value = 1 - pendingFitCenter.value = false - imageData.value = '' }) defineExpose({ @@ -425,12 +362,9 @@ defineExpose({ mdiFitToPageOutline, file, cropper, - cropperContainer, - resizeObserver, modal, image, imageData, - containerWidth, pendingFitCenter, zoomLevel, zoomMin, @@ -443,9 +377,6 @@ defineExpose({ zoomPercentValue, stencilAspectRatio, stencilProps, - defaultStencilSize, - initResizeObserver, - updateContainerWidth, updateZoomLevel, updateZoomLevelFromResult, zoomBy, diff --git a/src/tests/components/Draw/FileUpload.spec.ts b/src/tests/components/Draw/FileUpload.spec.ts index 4b78fcbfc5..f2b19d05ff 100644 --- a/src/tests/components/Draw/FileUpload.spec.ts +++ b/src/tests/components/Draw/FileUpload.spec.ts @@ -75,31 +75,18 @@ vi.mock('vue-advanced-cropper', () => ({ describe('FileUpload.vue - Uploaded signature flow', () => { beforeEach(() => { vi.clearAllMocks() - vi.stubGlobal('ResizeObserver', class { - observe = vi.fn() - disconnect = vi.fn() - }) }) function mountComponent() { return mount(FileUpload) } - it('initializes stencil dimensions from capabilities', () => { + it('keeps the configured signature aspect ratio', () => { const wrapper = mountComponent() expect(wrapper.vm.stencilBaseWidth).toBe(700) expect(wrapper.vm.stencilBaseHeight).toBe(200) - expect(wrapper.vm.defaultStencilSize).toEqual({ width: 700, height: 200 }) - }) - - it('scales the default stencil size to fit the cropper container', async () => { - const wrapper = mountComponent() - - wrapper.vm.containerWidth = 374 - await wrapper.vm.$nextTick() - - expect(wrapper.vm.defaultStencilSize).toEqual({ width: 350, height: 100 }) + expect(wrapper.vm.stencilAspectRatio).toBe(3.5) }) it('delegates initial crop selection size to the cropper', async () => { @@ -245,22 +232,19 @@ describe('FileUpload.vue - Uploaded signature flow', () => { }) it('resets crop state when the image is cleared', async () => { - const disconnect = vi.fn() const wrapper = mountComponent() - wrapper.vm.resizeObserver = { observe: vi.fn(), disconnect } - wrapper.vm.containerWidth = 480 wrapper.vm.zoomLevel = 2.4 wrapper.vm.pendingFitCenter = true wrapper.vm.image = 'data:image/png;base64,existing' + wrapper.vm.imageData = 'data:image/png;base64,old-crop' await wrapper.vm.$nextTick() wrapper.vm.image = '' await wrapper.vm.$nextTick() - expect(disconnect).toHaveBeenCalled() - expect(wrapper.vm.containerWidth).toBe(0) expect(wrapper.vm.zoomLevel).toBe(1) expect(wrapper.vm.pendingFitCenter).toBe(false) + expect(wrapper.vm.imageData).toBe('') }) }) From 5fd31e3440fc532c9fa28929794cd57f24e41154 Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Wed, 18 Nov 2026 02:26:37 +0000 Subject: [PATCH 3/5] test: bound cropped signature output dimensions Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> --- src/tests/components/Draw/FileUpload.spec.ts | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/src/tests/components/Draw/FileUpload.spec.ts b/src/tests/components/Draw/FileUpload.spec.ts index f2b19d05ff..cb8e6fbb67 100644 --- a/src/tests/components/Draw/FileUpload.spec.ts +++ b/src/tests/components/Draw/FileUpload.spec.ts @@ -59,7 +59,7 @@ vi.mock('vue-advanced-cropper', () => ({ Cropper: { name: 'Cropper', template: '
', - props: ['src', 'defaultSize', 'stencilProps', 'imageRestriction'], + props: ['src', 'defaultSize', 'stencilProps', 'imageRestriction', 'canvas'], emits: ['change'], methods: { zoom: vi.fn(), @@ -101,6 +101,23 @@ describe('FileUpload.vue - Uploaded signature flow', () => { expect(cropper.props('stencilProps')).toEqual({ aspectRatio: 3.5 }) }) + it('limits exported PNG dimensions while retaining source resolution for small images', async () => { + const wrapper = mountComponent() + wrapper.vm.image = 'data:image/png;base64,uploaded' + await wrapper.vm.$nextTick() + + const cropper = wrapper.findComponent({ name: 'Cropper' }) + const canvas = cropper.props('canvas') + + expect(canvas).toEqual({ + maxWidth: 2100, + maxHeight: 600, + maxArea: 1_000_000, + }) + expect(canvas).not.toHaveProperty('width') + expect(canvas).not.toHaveProperty('height') + }) + it('loads the selected file as a data URL', () => { const wrapper = mountComponent() const listeners = new Map void>>() From b5bb0d2c6ad9e442eea85c5c437b47231ac14426 Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Wed, 18 Nov 2026 02:27:05 +0000 Subject: [PATCH 4/5] fix: cap cropped signature PNG to backend size budget Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> --- src/components/Draw/FileUpload.vue | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/components/Draw/FileUpload.vue b/src/components/Draw/FileUpload.vue index ae2b3bcc39..5bf826c93d 100644 --- a/src/components/Draw/FileUpload.vue +++ b/src/components/Draw/FileUpload.vue @@ -22,6 +22,7 @@
@@ -210,6 +211,16 @@ const stencilProps = computed(() => ({ aspectRatio: stencilAspectRatio.value, })) +// Keep the source resolution where possible, but bound the exported PNG. +// A one-megapixel RGBA canvas stays under the backend's 5000 KiB image limit. +const canvasConstraints = computed(() => ({ + maxWidth: Number.isFinite(stencilBaseWidth) && stencilBaseWidth > 0 + ? stencilBaseWidth * 3 : undefined, + maxHeight: Number.isFinite(stencilBaseHeight) && stencilBaseHeight > 0 + ? stencilBaseHeight * 3 : undefined, + maxArea: 1_000_000, +})) + function updateZoomLevel(result?: CropperResult) { if (result) { updateZoomLevelFromResult(result) From 4c2cc7db97d3fe5f79327750a4ba6d8a550c6954 Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Wed, 18 Nov 2026 02:30:59 +0000 Subject: [PATCH 5/5] style: format cropper canvas constraints for ESLint Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> --- src/components/Draw/FileUpload.vue | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/Draw/FileUpload.vue b/src/components/Draw/FileUpload.vue index 5bf826c93d..7b5da31b68 100644 --- a/src/components/Draw/FileUpload.vue +++ b/src/components/Draw/FileUpload.vue @@ -215,9 +215,11 @@ const stencilProps = computed(() => ({ // A one-megapixel RGBA canvas stays under the backend's 5000 KiB image limit. const canvasConstraints = computed(() => ({ maxWidth: Number.isFinite(stencilBaseWidth) && stencilBaseWidth > 0 - ? stencilBaseWidth * 3 : undefined, + ? stencilBaseWidth * 3 + : undefined, maxHeight: Number.isFinite(stencilBaseHeight) && stencilBaseHeight > 0 - ? stencilBaseHeight * 3 : undefined, + ? stencilBaseHeight * 3 + : undefined, maxArea: 1_000_000, }))