Skip to content

[JitDiff X64] [EgorBo] Reduce Unsafe usage in primitive IBinaryInteger TryRe ... #1884

@MihuBot

Description

@MihuBot

Job completed in 2 minutes 57 seconds (remote runner delay: 0 seconds).
dotnet/runtime#127913

Main commit: dotnet/runtime@feeb7b9
PR commit: EgorBo/runtime-1@140ce16

Diffs

Found 82 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46154992
Total bytes of diff: 46154917
Total bytes of delta: -75 (-0.00 % of base)
Total relative delta: -0.40
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
         -75 : System.Private.CoreLib.dasm (-0.00 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 259 unchanged.

Top method improvements (bytes):
         -18 (-11.25 % of base) : System.Private.CoreLib.dasm - System.UInt32:System.Numerics.IBinaryInteger<System.UInt32>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
         -18 (-11.25 % of base) : System.Private.CoreLib.dasm - System.UInt64:System.Numerics.IBinaryInteger<System.UInt64>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
         -18 (-11.25 % of base) : System.Private.CoreLib.dasm - System.UIntPtr:System.Numerics.IBinaryInteger<nuint>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -9 (-1.86 % of base) : System.Private.CoreLib.dasm - System.Int128:System.Numerics.IBinaryInteger<System.Int128>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -6 (-2.56 % of base) : System.Private.CoreLib.dasm - System.UInt128:System.Numerics.IBinaryInteger<System.UInt128>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -2 (-0.73 % of base) : System.Private.CoreLib.dasm - System.Int32:System.Numerics.IBinaryInteger<System.Int32>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -2 (-0.72 % of base) : System.Private.CoreLib.dasm - System.Int64:System.Numerics.IBinaryInteger<System.Int64>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -2 (-0.72 % of base) : System.Private.CoreLib.dasm - System.IntPtr:System.Numerics.IBinaryInteger<nint>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)

Top method improvements (percentages):
         -18 (-11.25 % of base) : System.Private.CoreLib.dasm - System.UInt32:System.Numerics.IBinaryInteger<System.UInt32>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
         -18 (-11.25 % of base) : System.Private.CoreLib.dasm - System.UInt64:System.Numerics.IBinaryInteger<System.UInt64>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
         -18 (-11.25 % of base) : System.Private.CoreLib.dasm - System.UIntPtr:System.Numerics.IBinaryInteger<nuint>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -6 (-2.56 % of base) : System.Private.CoreLib.dasm - System.UInt128:System.Numerics.IBinaryInteger<System.UInt128>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -9 (-1.86 % of base) : System.Private.CoreLib.dasm - System.Int128:System.Numerics.IBinaryInteger<System.Int128>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -2 (-0.73 % of base) : System.Private.CoreLib.dasm - System.Int32:System.Numerics.IBinaryInteger<System.Int32>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -2 (-0.72 % of base) : System.Private.CoreLib.dasm - System.Int64:System.Numerics.IBinaryInteger<System.Int64>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          -2 (-0.72 % of base) : System.Private.CoreLib.dasm - System.IntPtr:System.Numerics.IBinaryInteger<nint>.TryReadLittleEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)

8 total methods with Code Size differences (8 improved, 0 regressed), 286907 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions