Skip to content

[JitDiff X64] [xtqqczze] Add AggressiveInlining to hex conversion methods #1888

@MihuBot

Description

@MihuBot

Job completed in 15 minutes 35 seconds (remote runner delay: 1 minute 8 seconds).
dotnet/runtime#127930

Main commit: dotnet/runtime@a6bc864
PR commit: xtqqczze/dotnet-runtime@35fb9a7

Diffs

Found 87 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46158194
Total bytes of diff: 46158670
Total bytes of delta: 476 (0.00 % of base)
Total relative delta: 1.16
    diff is a regression.
    relative diff is a regression.


Top file regressions (bytes):
         410 : System.Private.Uri.dasm (0.40 % of base)
          48 : System.Net.NetworkInformation.dasm (0.09 % of base)
          18 : System.Net.Http.dasm (0.00 % of base)

3 total files with Code Size differences (0 improved, 3 regressed), 257 unchanged.

Top method regressions (bytes):
         118 (9.55 % of base) : System.Private.Uri.dasm - System.UriHelper:UnescapeString(System.ReadOnlySpan`1[char],byref,char,char,char,int,System.UriParser,bool) (FullOpts)
          78 (6.01 % of base) : System.Private.Uri.dasm - System.IriHelper:EscapeUnescapeIri(byref,System.ReadOnlySpan`1[char],bool) (FullOpts)
          66 (24.00 % of base) : System.Private.Uri.dasm - System.Uri:CheckForUnicodeOrEscapedUnreserved(System.String):bool (FullOpts)
          64 (28.44 % of base) : System.Private.Uri.dasm - System.Uri:UnescapePathSlashesAndDots(byref,int,bool) (FullOpts)
          56 (12.42 % of base) : System.Private.Uri.dasm - System.UriHelper:Unescape(System.ReadOnlySpan`1[char],byref) (FullOpts)
          54 (23.58 % of base) : System.Private.Uri.dasm - System.Uri:HexUnescape(System.String,byref):char (FullOpts)
          48 (12.63 % of base) : System.Net.NetworkInformation.dasm - System.Net.NetworkInformation.StringParsingHelpers:ParseIPv6HexString(System.ReadOnlySpan`1[char],bool):System.Net.IPAddress (FullOpts)
          18 (1.72 % of base) : System.Net.Http.dasm - System.Net.Http.Headers.ContentDispositionHeaderValue:TryDecode5987(System.String,byref):bool (FullOpts)

Top method improvements (bytes):
         -26 (-2.32 % of base) : System.Private.Uri.dasm - System.Uri:CheckCanonical(System.ReadOnlySpan`1[char],char,byref):int:this (FullOpts)

Top method regressions (percentages):
          64 (28.44 % of base) : System.Private.Uri.dasm - System.Uri:UnescapePathSlashesAndDots(byref,int,bool) (FullOpts)
          66 (24.00 % of base) : System.Private.Uri.dasm - System.Uri:CheckForUnicodeOrEscapedUnreserved(System.String):bool (FullOpts)
          54 (23.58 % of base) : System.Private.Uri.dasm - System.Uri:HexUnescape(System.String,byref):char (FullOpts)
          48 (12.63 % of base) : System.Net.NetworkInformation.dasm - System.Net.NetworkInformation.StringParsingHelpers:ParseIPv6HexString(System.ReadOnlySpan`1[char],bool):System.Net.IPAddress (FullOpts)
          56 (12.42 % of base) : System.Private.Uri.dasm - System.UriHelper:Unescape(System.ReadOnlySpan`1[char],byref) (FullOpts)
         118 (9.55 % of base) : System.Private.Uri.dasm - System.UriHelper:UnescapeString(System.ReadOnlySpan`1[char],byref,char,char,char,int,System.UriParser,bool) (FullOpts)
          78 (6.01 % of base) : System.Private.Uri.dasm - System.IriHelper:EscapeUnescapeIri(byref,System.ReadOnlySpan`1[char],bool) (FullOpts)
          18 (1.72 % of base) : System.Net.Http.dasm - System.Net.Http.Headers.ContentDispositionHeaderValue:TryDecode5987(System.String,byref):bool (FullOpts)

Top method improvements (percentages):
         -26 (-2.32 % of base) : System.Private.Uri.dasm - System.Uri:CheckCanonical(System.ReadOnlySpan`1[char],char,byref):int:this (FullOpts)

9 total methods with Code Size differences (1 improved, 8 regressed), 286912 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions