Skip to content

[JitDiff X64] [EgorBo] JIT: Fold redundant CHKCAST through VN-to-handle asse ... #1891

@MihuBot

Description

@MihuBot

Job completed in 2 minutes 25 seconds (remote runner delay: 0 seconds).
dotnet/runtime#127956

Main commit: dotnet/runtime@0fc4413
PR commit: EgorBo/runtime-1@628ad07

Diffs

Found 86 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46155607
Total bytes of diff: 46155312
Total bytes of delta: -295 (-0.00 % of base)
Total relative delta: -0.55
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
        -111 : System.Text.Json.dasm (-0.01 % of base)
        -105 : System.Private.CoreLib.dasm (-0.00 % of base)
         -79 : System.Data.Common.dasm (-0.00 % of base)

3 total files with Code Size differences (3 improved, 0 regressed), 257 unchanged.

Top method improvements (bytes):
        -105 (-13.89 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.Marshalling.ComVariant:As[System.__Canon]():System.__Canon:this (FullOpts)
         -79 (-0.42 % of base) : System.Data.Common.dasm - System.Data.BinaryNode:EvalBinaryOp(int,System.Data.ExpressionNode,System.Data.ExpressionNode,System.Data.DataRow,int,int[]):System.Object:this (FullOpts)
         -41 (-6.59 % of base) : System.Text.Json.dasm - System.Text.Json.Nodes.JsonValueOfJsonString:TryGetValue[System.__Canon](byref):bool:this (FullOpts)
         -35 (-16.43 % of base) : System.Text.Json.dasm - System.Text.Json.Nodes.JsonValueOfJsonBool:TryGetValue[System.__Canon](byref):bool:this (FullOpts)
         -35 (-17.33 % of base) : System.Text.Json.dasm - System.Text.Json.Nodes.JsonValueOfJsonNumber:TryGetValue[System.__Canon](byref):bool:this (FullOpts)

Top method improvements (percentages):
         -35 (-17.33 % of base) : System.Text.Json.dasm - System.Text.Json.Nodes.JsonValueOfJsonNumber:TryGetValue[System.__Canon](byref):bool:this (FullOpts)
         -35 (-16.43 % of base) : System.Text.Json.dasm - System.Text.Json.Nodes.JsonValueOfJsonBool:TryGetValue[System.__Canon](byref):bool:this (FullOpts)
        -105 (-13.89 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.Marshalling.ComVariant:As[System.__Canon]():System.__Canon:this (FullOpts)
         -41 (-6.59 % of base) : System.Text.Json.dasm - System.Text.Json.Nodes.JsonValueOfJsonString:TryGetValue[System.__Canon](byref):bool:this (FullOpts)
         -79 (-0.42 % of base) : System.Data.Common.dasm - System.Data.BinaryNode:EvalBinaryOp(int,System.Data.ExpressionNode,System.Data.ExpressionNode,System.Data.DataRow,int,int[]):System.Object:this (FullOpts)

5 total methods with Code Size differences (5 improved, 0 regressed), 286910 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions