Repository navigation
Vouch request: fix for #5322 (502 on empty upstream response) #5337
simin-yuan
started this conversation in
Vouch Request
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hi maintainers,
I'm writing to request a vouch so I can open a PR for issue #5322.
I'm an independent researcher working on agent reliability, and I've previously landed two merged PRs in NVIDIA/NeMo-Agent-Toolkit: NVIDIA/NeMo-Agent-Toolkit#2551 and NVIDIA/NeMo-Agent-Toolkit#2553.
The root of this issue is a silent failure case: when the upstream returns zero bytes, the relay sends nothing back to the client, so the client gets no response at all.
My proposed fix only covers the second acceptance criterion: using
write_bad_gateway_responseto return a 502 response withConnection: close. I'm leaving the first criterion (retrying against a fresh upstream) untouched — that's a design decision better left to the maintainer team.I'll run fork CI across Windows and Ubuntu to validate the change before opening the PR.
Could you grant a vouch for this work?
Thanks, Simin Yuan
All reactions