This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Add oncall display name when sending option to page the oncall#5906
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the event paging functionality to include the on-call display name in the notification message when paging is triggered. The changes involve modifying the function signature in messaging.py and updating its invocation in flows.py to support dynamic display of the oncall name.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/dispatch/case/messaging.py | Updated send_event_paging_message signature and notification text to include oncall_name. |
| src/dispatch/case/flows.py | Modified call to send_event_paging_message to pass in the oncall_name. |
Comments suppressed due to low confidence (1)
src/dispatch/case/messaging.py:380
- Consider updating the docstring for send_event_paging_message to document the new oncall_name parameter for improved clarity.
def send_event_paging_message(case: Case, db_session: Session, oncall_name: str):
ghost
reviewed
Apr 18, 2025
ghost
approved these changes
Apr 18, 2025
ghost
reviewed
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the event paging message functionality by dynamically including the on-call team's name in the notification. The changes ensure better clarity for users by specifying the relevant team to contact for immediate assistance.
Example:
