This repository was archived by the owner on Sep 3, 2025. It is now read-only.
feat(entity): when a new entity_type is created, find new entities#5908
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends entity_type creation functionality by propagating the new type to previously created signal instances, enabling immediate use in snooze operations. Key changes include:
- Updating JSON path handling in the jpath utility.
- Enhancing the NewRawSignalViewer component by adding hover provider cleanup and combining entity sources.
- Revising the EntityTypeCreateDialogV2 UI and backend service logic for entity extraction.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/dispatch/static/dispatch/src/util/jpath.ts | Changed array path formatting to use wildcards. |
| src/dispatch/static/dispatch/src/signal/NewRawSignalViewer.vue | Added cleanup and re-registration of hover providers. |
| src/dispatch/static/dispatch/src/entity_type/EntityTypeCreateDialogV2.vue | Adjusted editor height style. |
| src/dispatch/entity_type/service.py | Added logic to back propagate new entity_type creation to signal instances. |
Comments suppressed due to low confidence (1)
src/dispatch/entity_type/service.py:83
- The variable 'signals' is not defined in this context. Please ensure that the relevant signals are retrieved or defined before iterating over them.
for signal in signals:
aliciamatsumoto
approved these changes
Apr 18, 2025
ghost
reviewed
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the entity_type creation to back propagate the creation of entities based on these types to previous signal instances. This allows a user to create a new entity_type and use it immediately in a snooze.