Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

feat(entity): when a new entity_type is created, find new entities#5908

Merged
whitdog47 merged 8 commits into
mainfrom
enhancement/add-entity-improvement
Apr 23, 2025
Merged

feat(entity): when a new entity_type is created, find new entities#5908
whitdog47 merged 8 commits into
mainfrom
enhancement/add-entity-improvement

Conversation

@whitdog47
Copy link
Copy Markdown
Contributor

@whitdog47 whitdog47 commented Apr 18, 2025

This PR updates the entity_type creation to back propagate the creation of entities based on these types to previous signal instances. This allows a user to create a new entity_type and use it immediately in a snooze.

@whitdog47 whitdog47 added the enhancement New feature or request label Apr 18, 2025
@whitdog47 whitdog47 self-assigned this Apr 18, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends entity_type creation functionality by propagating the new type to previously created signal instances, enabling immediate use in snooze operations. Key changes include:

  • Updating JSON path handling in the jpath utility.
  • Enhancing the NewRawSignalViewer component by adding hover provider cleanup and combining entity sources.
  • Revising the EntityTypeCreateDialogV2 UI and backend service logic for entity extraction.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/dispatch/static/dispatch/src/util/jpath.ts Changed array path formatting to use wildcards.
src/dispatch/static/dispatch/src/signal/NewRawSignalViewer.vue Added cleanup and re-registration of hover providers.
src/dispatch/static/dispatch/src/entity_type/EntityTypeCreateDialogV2.vue Adjusted editor height style.
src/dispatch/entity_type/service.py Added logic to back propagate new entity_type creation to signal instances.
Comments suppressed due to low confidence (1)

src/dispatch/entity_type/service.py:83

  • The variable 'signals' is not defined in this context. Please ensure that the relevant signals are retrieved or defined before iterating over them.
for signal in signals:

Comment thread src/dispatch/entity_type/service.py
@whitdog47 whitdog47 merged commit ce6da69 into main Apr 23, 2025
9 checks passed
@whitdog47 whitdog47 deleted the enhancement/add-entity-improvement branch April 23, 2025 23:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants