Skip to content

[18.0][FIX] edi_storage_oca: ls whitespace filename with ftp protocol#224

Open
ArnauCForgeFlow wants to merge 1 commit into
OCA:18.0from
ForgeFlow:18.0-fix-edi_storage_oca-ftp_ls
Open

[18.0][FIX] edi_storage_oca: ls whitespace filename with ftp protocol#224
ArnauCForgeFlow wants to merge 1 commit into
OCA:18.0from
ForgeFlow:18.0-fix-edi_storage_oca-ftp_ls

Conversation

@ArnauCForgeFlow
Copy link
Copy Markdown
Contributor

The method fs.ls() fails to correctly parse FTP filenames with spaces. This change bypasses fs.ls for the FTP protocol and uses the underlying fs.ftp.nlst() method directly, which returns the correct full filenames.

Assume a directory /data exists on the FTP server containing a file named "my file.txt".

Actual output when using fs.ls with ftp protocol:
['/data/file.txt']

Expected Output:
['/data/my file.txt']

Since this seems to be a bug in the fsspec library, I used fs.ftp.nlst() as a workaround. I've also reported the issue on their GitHub: fsspec/filesystem_spec#1970

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants