fix: test_tool_document_to_oscal_with_hyphenated_tool_id fails with missing ltype argument

[shiwani42]

Issue

What is the issue?

test_tool_document_to_oscal_with_hyphenated_tool_id in application/tests/oscal_utils_test.py (line 224) constructs a defs.Link without passing the required ltype argument. The Link dataclass was updated to make ltype a required positional argument, but the test was not updated accordingly.

Expected Behaviour

The test should pass by providing a valid ltype argument when constructing defs.Link.

Actual Behaviour

The test raises a TypeError and fails:

TypeError: Link.__init__() missing 1 required positional argument: 'ltype'

Steps to reproduce

python3 -m pytest application/tests/oscal_utils_test.py::TestOSCALUtils::test_tool_document_to_oscal_with_hyphenated_tool_id -v

Suggested fix: Add ltype=defs.LinkTypes.LinkedTo to the defs.Link(...) constructor call in application/tests/oscal_utils_test.py line 224.

[shiwani42]

Hi @Pa04rth, is this a valid issue? Happy to raise a PR if so.