From 9393e74963bd703532e1f3ac33fefc7a25524013 Mon Sep 17 00:00:00 2001 From: Jim Manico Date: Mon, 16 Nov 2026 20:18:55 -0500 Subject: [PATCH 1/2] Pin fixed Guava and OpenTelemetry in build and fixture graphs GHSA-xxph-c9ww-hj94 affects Guava through 33.7.1 and GHSA-ccrj-gw8r-854m affects OpenTelemetry Java through 1.66.0. Both reached the repository only through build-plugin realms and the unpublished Jakarta fixture's Selenium test classpath. Pin Guava 33.7.2-jre in the Checkstyle, japicmp (exec), WAR and Central publisher plugin realms and in the fixture's dependency management, and raise the fixture's Boot-managed OpenTelemetry BOM to 1.67.0. Selenium stays on 4.49.0 to match the digest-pinned browser image. Published library dependencies are unchanged. --- .github/DEPENDENCY_DECISIONS.md | 27 +++++++++++++++++++++++++++ CHANGELOG.md | 4 ++++ jakarta-test/README.md | 7 +++++-- jakarta-test/pom.xml | 13 +++++++++++++ pom.xml | 8 ++++++++ 5 files changed, 57 insertions(+), 2 deletions(-) diff --git a/.github/DEPENDENCY_DECISIONS.md b/.github/DEPENDENCY_DECISIONS.md index 21cc3c4..4d535d7 100644 --- a/.github/DEPENDENCY_DECISIONS.md +++ b/.github/DEPENDENCY_DECISIONS.md @@ -141,6 +141,33 @@ Credential scoping is the one release-path change this review cannot exercise without the project's Central token. The first signed `clean deploy` under 3.10.0 should confirm that staging still authenticates before the release relies on it. +## Guava and OpenTelemetry build/test pins — 2026-11-16 + +[GHSA-xxph-c9ww-hj94](https://github.com/advisories/GHSA-xxph-c9ww-hj94) +affects Guava through 33.7.1 and is fixed in **33.7.2**. +[GHSA-ccrj-gw8r-854m](https://github.com/advisories/GHSA-ccrj-gw8r-854m) +affects OpenTelemetry Java through 1.66.0 and is fixed in **1.67.0**. GitHub +reported both only on build-plugin realms and the unpublished Jakarta fixture's +test classpath. No published library depends on either. + +Guava 33.7.2-jre is pinned directly in each executed plugin realm that brought an +affected copy: Checkstyle 12.3.1 (33.5.0) in the root and fixture builds, the +japicmp engine run by `exec-maven-plugin` (33.4.8), `central-publishing-maven-plugin` +(32.1.0, pinned in plugin management so the release profile's existing publisher +mitigations still merge with it), and the fixture's WAR plugin through Guice +(33.4.8). In the fixture, Selenium 4.49.0 brings Guava 33.7.1, so its dependency +management pins 33.7.2-jre, and the `opentelemetry.version` property raises Boot +4.1.2's managed OpenTelemetry BOM from 1.62.0 to 1.67.0 for Selenium's tracing. + +Selenium stays on 4.49.0 because the client is aligned with the digest-pinned +browser image. Selenium 4.52.0 already depends on Guava 33.7.2 and OpenTelemetry +1.67.0, so a later reviewed client-and-image update can drop the fixture's +dependency-management pin; drop the OpenTelemetry property once Boot manages +1.67.0 or newer. Remove each plugin-realm Guava pin when that plugin's own graph +reaches 33.7.2. `kotlin-maven-plugin` appears in the fixture's resolved plugin +list with Guava 33.5.0 through Boot's plugin management, but the fixture never +executes it and the dependency submission does not include it. + ## Deferred proposals and reconsideration conditions | Proposal | Disposition and required evidence before reconsideration | diff --git a/CHANGELOG.md b/CHANGELOG.md index 5f1f70f..740aa31 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,10 @@ unchanged. [1.6.0 is available from Central](releases/1.6.0-central-publication. exceeds. Refresh Maven build plugins, plexus-archiver, japicmp, and the test/publisher-only Jackson 2.22.4. Published library dependencies are unchanged. +- Pin Guava 33.7.2 in the Checkstyle, japicmp, WAR and Central publisher + plugin realms and the Jakarta fixture's Selenium tests, and raise the + fixture's OpenTelemetry to 1.67.0, for GHSA-xxph-c9ww-hj94 and + GHSA-ccrj-gw8r-854m. Published library dependencies are unchanged. ## 1.6.0 — 2026-10-18 UTC diff --git a/jakarta-test/README.md b/jakarta-test/README.md index 64b2c99..51c7a35 100644 --- a/jakarta-test/README.md +++ b/jakarta-test/README.md @@ -40,8 +40,11 @@ A local Chrome-only diagnostic for the JavaScript suite remains available with As reviewed on 2026-10-26, this fixture uses supported Spring Boot **4.1.2** and its managed dependencies, on JDK **17**, with Tomcat/Jasper **11.0.27** -(Servlet **6.1**, Pages **4.0**, EL **6.0**). The one deliberate BOM override is -Selenium 4.49.0, aligned with the current reviewed browser image. +(Servlet **6.1**, Pages **4.0**, EL **6.0**). The deliberate BOM override is +Selenium 4.49.0, aligned with the current reviewed browser image. Its test-only +Guava (**33.7.2**) and OpenTelemetry (**1.67.0**) are raised to the first +releases that fix GHSA-xxph-c9ww-hj94 and GHSA-ccrj-gw8r-854m; see the +[dependency decisions](../.github/DEPENDENCY_DECISIONS.md). Testcontainers **2.0.5**, JSTL API **3.0.2** and implementation **3.0.1** follow the Boot BOM. The standalone Servlet/Pages/EL API JARs are removed; Tomcat supplies the coherent implementation/API set. Both JSTL components remain packaged. diff --git a/jakarta-test/pom.xml b/jakarta-test/pom.xml index 16576e8..5ef4d99 100644 --- a/jakarta-test/pom.xml +++ b/jakarta-test/pom.xml @@ -24,10 +24,19 @@ 17 4.49.0 + + 1.67.0 1.6.1-SNAPSHOT + + + + com.google.guavaguava33.7.2-jre + + org.owasp.encoder @@ -114,6 +123,8 @@ org.apache.commonscommons-lang33.21.0 org.codehaus.plexusplexus-archiver4.15.0 org.codehaus.plexusplexus-utils4.0.3 + + com.google.guavaguava33.7.2-jre ${maven.multiModuleProjectDirectory}/src/main/config/checkstyle.xml @@ -190,6 +201,8 @@ org.codehaus.plexusplexus-archiver4.15.0 org.codehaus.plexusplexus-utils4.0.3 + + com.google.guavaguava33.7.2-jre diff --git a/pom.xml b/pom.xml index da3ff81..5290bbe 100644 --- a/pom.xml +++ b/pom.xml @@ -343,6 +343,8 @@ japicmp 0.27.0 + + com.google.guavaguava33.7.2-jre @@ -375,6 +377,10 @@ org.sonatype.central central-publishing-maven-plugin 0.12.0 + + + com.google.guavaguava33.7.2-jre + @@ -416,6 +422,8 @@ org.apache.commonscommons-lang33.21.0 org.codehaus.plexusplexus-archiver4.15.0 org.codehaus.plexusplexus-utils4.0.3 + + com.google.guavaguava33.7.2-jre ${maven.multiModuleProjectDirectory}/src/main/config/checkstyle.xml From 5234104c99aba78d73428f08e78460195835c499 Mon Sep 17 00:00:00 2001 From: Jim Manico Date: Mon, 16 Nov 2026 20:22:13 -0500 Subject: [PATCH 2/2] Record that the publisher Guava pin is resolved, not yet executed --- .github/DEPENDENCY_DECISIONS.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/DEPENDENCY_DECISIONS.md b/.github/DEPENDENCY_DECISIONS.md index 4d535d7..d478f6f 100644 --- a/.github/DEPENDENCY_DECISIONS.md +++ b/.github/DEPENDENCY_DECISIONS.md @@ -168,6 +168,12 @@ reaches 33.7.2. `kotlin-maven-plugin` appears in the fixture's resolved plugin list with Guava 33.5.0 through Boot's plugin management, but the fixture never executes it and the dependency submission does not include it. +`./mvnw verify` exercises the new Guava in the Checkstyle and japicmp realms, +and packaging the fixture exercises it in the fixture's Checkstyle and WAR +realms. The publisher realm was resolved, not executed, because there is no +publishing run that skips signing and Central credentials. The next signed +release rehearsal should confirm it before a release relies on it. + ## Deferred proposals and reconsideration conditions | Proposal | Disposition and required evidence before reconsideration |