From 664da4a1a866a9c2b94ce9b3b2dc1c1ed1d5f226 Mon Sep 17 00:00:00 2001 From: LukasGold <41064839+LukasGold@users.noreply.github.com> Date: Thu, 5 Nov 2026 18:26:00 +0100 Subject: [PATCH] feat: derive Property page title from name in get_title - return entity.name for Property instances without meta title - apply in opensemantic and opensemantic.v1 - add opensemantic.core to testing extra - add tests for both model versions --- setup.cfg | 1 + src/opensemantic/_model.py | 4 +++ src/opensemantic/v1/_model.py | 4 +++ tests/property_title_test.py | 61 +++++++++++++++++++++++++++++++++++ 4 files changed, 70 insertions(+) create mode 100644 tests/property_title_test.py diff --git a/setup.cfg b/setup.cfg index 789a6de..9ba728e 100644 --- a/setup.cfg +++ b/setup.cfg @@ -66,6 +66,7 @@ testing = setuptools pytest pytest-cov + opensemantic.core [options.entry_points] # Add here console scripts like: diff --git a/src/opensemantic/_model.py b/src/opensemantic/_model.py index d3e03e4..78894fd 100644 --- a/src/opensemantic/_model.py +++ b/src/opensemantic/_model.py @@ -313,6 +313,10 @@ def get_title(entity: OswBaseModel) -> Union[str, NoneType]: if entity.meta.wiki_page.title: title = entity.meta.wiki_page.title + if title is None and custom_isinstance(entity, "Property"): + # Same rule as the wiki form editor: the name of a property is its title + title = getattr(entity, "name", None) or None + if title is None: title = get_osw_id(entity) diff --git a/src/opensemantic/v1/_model.py b/src/opensemantic/v1/_model.py index b541394..9278150 100644 --- a/src/opensemantic/v1/_model.py +++ b/src/opensemantic/v1/_model.py @@ -318,6 +318,10 @@ def get_title(entity: OswBaseModel) -> Union[str, NoneType]: if entity.meta.wiki_page.title: title = entity.meta.wiki_page.title + if title is None and custom_isinstance(entity, "Property"): + # Same rule as the wiki form editor: the name of a property is its title + title = getattr(entity, "name", None) or None + if title is None: title = get_osw_id(entity) diff --git a/tests/property_title_test.py b/tests/property_title_test.py new file mode 100644 index 0000000..734da28 --- /dev/null +++ b/tests/property_title_test.py @@ -0,0 +1,61 @@ +"""Tests for deriving the wiki page title of a Property from its name.""" + +import pytest + + +def _classes(version): + if version == "v2": + from opensemantic.core import AnnotationProperty, Item, QuantityProperty + else: + from opensemantic.core.v1 import AnnotationProperty, Item, QuantityProperty + return AnnotationProperty, QuantityProperty, Item + + +LABEL = [{"text": "label"}] + + +@pytest.mark.parametrize("version", ["v2", "v1"]) +@pytest.mark.parametrize("cls_index", [0, 1]) +def test_property_title_from_name(version, cls_index): + cls = _classes(version)[cls_index] + prop = cls(name="HasTestValue", label=LABEL) + assert prop.get_title() == "HasTestValue" + assert prop.get_iri() == "Property:HasTestValue" + + +@pytest.mark.parametrize("version", ["v2", "v1"]) +def test_property_explicit_meta_title_wins(version): + prop_cls = _classes(version)[0] + prop = prop_cls( + name="HasTestValue", + label=LABEL, + meta={"wiki_page": {"title": "Custom"}}, + ) + assert prop.get_title() == "Custom" + assert prop.get_iri() == "Property:Custom" + + +@pytest.mark.parametrize("version", ["v2", "v1"]) +def test_non_property_title_is_osw_id(version): + item_cls = _classes(version)[2] + item = item_cls(label=LABEL, name="SomeName") + assert item.get_title() == f"OSW{item.uuid.hex}" + assert item.get_iri() == f"Item:OSW{item.uuid.hex}" + + +@pytest.mark.parametrize("version", ["v2", "v1"]) +def test_property_with_empty_name_falls_back_to_osw_id(version): + prop_cls = _classes(version)[0] + prop = prop_cls(name="HasTestValue", label=LABEL) + # the model rejects None as name, so an empty string is the only unset value + prop.name = "" + assert prop.get_title() == f"OSW{prop.uuid.hex}" + assert prop.get_iri() == f"Property:OSW{prop.uuid.hex}" + + +@pytest.mark.parametrize("version", ["v2", "v1"]) +def test_property_name_derived_from_label_is_used_as_title(version): + prop_cls = _classes(version)[0] + prop = prop_cls(label=LABEL) + assert prop.name + assert prop.get_title() == prop.name