(For Analytics Prototype instead of v2) Change key names for sessionDepth and pageAuctionsCount in Analytics …#290
Merged
Conversation
mosherBT
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…prototype
In a nutshell, both the prototype and prod version of analytics are incrementing these values:
Which means that the values are reported in double.
Example:
Same thing happens for pageAuctionsCount, which will return 1 for the first analytics loaded and then 2 for the second analytics loaded. One of them is not correct, but we cannot find which one is wrong.
This PR changes the sessionStorage key and javascript variable names to avoid this conflict.
I decided to edit the prototype one so that we can keep the prod/V2 one with the same key/variable name as the names in the analytics, avoid confusion in the future.