Skip to content

Commit b439e04

Browse files
LocalIdentityLocalIdentity
andauthored
Fix Generals Cry damage calculation with some skill (#9663)
The dpsMultiplier was overwriting the dpsMultiplier from other skill like Lacerate so selecting double slash with lacerate and GC would not include the 2x dps multi from both slashes hitting Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent 3e8e8bc commit b439e04

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/Modules/CalcMirages.lua

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -393,15 +393,15 @@ function calcs.mirages(env)
393393
if env.player.mainSkill.skillTypes[SkillType.Channel] then
394394
mirageSpawnTime = mirageSpawnTime + 1
395395
else
396-
mirageSpawnTime = mirageSpawnTime + (mainSkillOutputCache.HitTime or mainSkillOutputCache.Time)
396+
mirageSpawnTime = mirageSpawnTime
397397
env.player.mainSkill.skillData.timeOverride = 1
398398
end
399399

400400
-- This is so that it's consistent with the info message but removing this could make it more accurate numbers wise
401401
mirageSpawnTime = round(mirageSpawnTime, 2)
402402

403403
-- Scale dps with GC's cooldown
404-
env.player.mainSkill.skillData.dpsMultiplier = (env.player.mainSkill.skillData.dpsMultiplier or 1) * (1 / cooldown)
404+
env.player.mainSkill.skillModList:NewMod("DPS", "MORE", (1 / cooldown - 1) * 100, "General's Cry Cooldown")
405405

406406
-- Does not use player resources
407407
env.player.mainSkill.skillModList:NewMod("HasNoCost", "FLAG", true, "Used by mirage")

0 commit comments

Comments
 (0)