From 533a856edfad7644b47835b579e2b9038ed2b581 Mon Sep 17 00:00:00 2001 From: LocalIdentity Date: Tue, 17 Mar 2026 10:48:42 +1100 Subject: [PATCH] Fix Generals Cry damage calculation with some skill The dpsMultiplier was overwriting the dpsMultiplier from other skill like Lacerate so selecting double slash with lacerate and GC would not include the 2x dps multi from both slashes hitting --- src/Modules/CalcMirages.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Modules/CalcMirages.lua b/src/Modules/CalcMirages.lua index bdd0f5ebb4..87bcf8e3db 100644 --- a/src/Modules/CalcMirages.lua +++ b/src/Modules/CalcMirages.lua @@ -393,7 +393,7 @@ function calcs.mirages(env) if env.player.mainSkill.skillTypes[SkillType.Channel] then mirageSpawnTime = mirageSpawnTime + 1 else - mirageSpawnTime = mirageSpawnTime + (mainSkillOutputCache.HitTime or mainSkillOutputCache.Time) + mirageSpawnTime = mirageSpawnTime env.player.mainSkill.skillData.timeOverride = 1 end @@ -401,7 +401,7 @@ function calcs.mirages(env) mirageSpawnTime = round(mirageSpawnTime, 2) -- Scale dps with GC's cooldown - env.player.mainSkill.skillData.dpsMultiplier = (env.player.mainSkill.skillData.dpsMultiplier or 1) * (1 / cooldown) + env.player.mainSkill.skillModList:NewMod("DPS", "MORE", (1 / cooldown - 1) * 100, "General's Cry Cooldown") -- Does not use player resources env.player.mainSkill.skillModList:NewMod("HasNoCost", "FLAG", true, "Used by mirage")