From bec33fbc883162fbb529c62afc585fcad8712fbc Mon Sep 17 00:00:00 2001 From: ScriptedAlchemy Date: Mon, 16 Nov 2026 00:28:29 -0800 Subject: [PATCH 1/2] test(code-index): pin submodule opt-in boundaries --- .../src/ast_grep_search.rs | 48 +++++++++++++++++++ .../tracedecay-code-index/src/grep_search.rs | 38 +++++++++++++++ .../tracedecay-code-index/src/source_walk.rs | 17 +++++++ 3 files changed, 103 insertions(+) diff --git a/crates/tracedecay-code-index/src/ast_grep_search.rs b/crates/tracedecay-code-index/src/ast_grep_search.rs index 32ef5b76a03..af10e8d01d8 100644 --- a/crates/tracedecay-code-index/src/ast_grep_search.rs +++ b/crates/tracedecay-code-index/src/ast_grep_search.rs @@ -831,4 +831,52 @@ mod tests { ); assert!(result.lines_visited < TOTAL_LINES); } + + #[test] + fn submodule_sources_are_parsed_only_under_the_opt_in() { + let fixture = crate::source_walk::submodules::tests::fixture(); + let parent = fixture.path().join("parent"); + let disabled = search_tree( + &parent, + "pub fn $N() {}", + Some("rust"), + None, + 10, + &no_exclusions(), + ) + .expect("default ast-grep"); + assert!( + disabled + .matches + .iter() + .any(|hit| hit.file.as_ref() == "parent.rs"), + "the parent source is parsed: {:?}", + disabled.matches + ); + assert!( + disabled + .matches + .iter() + .all(|hit| !hit.file.starts_with("app/")), + "{:?}", + disabled.matches + ); + let enabled = search_tree( + &parent, + "pub fn $N() {}", + Some("rust"), + None, + 10, + &no_exclusions().with_submodules(true), + ) + .expect("opt-in ast-grep"); + assert!( + enabled + .matches + .iter() + .any(|hit| hit.file.as_ref() == "app/first.rs"), + "{:?}", + enabled.matches + ); + } } diff --git a/crates/tracedecay-code-index/src/grep_search.rs b/crates/tracedecay-code-index/src/grep_search.rs index b174387dcb6..7bb5f518881 100644 --- a/crates/tracedecay-code-index/src/grep_search.rs +++ b/crates/tracedecay-code-index/src/grep_search.rs @@ -582,4 +582,42 @@ mod tests { ); assert!(result.lines_visited < TOTAL_LINES); } + + #[test] + fn submodule_sources_are_searchable_only_under_the_opt_in() { + let fixture = crate::source_walk::submodules::tests::fixture(); + let parent = fixture.path().join("parent"); + let mut query = query("pub fn"); + query.max_results = 10; + let disabled = search_tree_with_cancel(&parent, &query, &no_exclusions(), || false) + .expect("default grep"); + assert!( + disabled + .hits + .iter() + .any(|hit| hit.file.as_ref() == "parent.rs"), + "the parent source is searched: {:?}", + disabled.hits + ); + assert!( + disabled.hits.iter().all(|hit| !hit.file.starts_with("app/")), + "{:?}", + disabled.hits + ); + let enabled = search_tree_with_cancel( + &parent, + &query, + &no_exclusions().with_submodules(true), + || false, + ) + .expect("opt-in grep"); + assert!( + enabled + .hits + .iter() + .any(|hit| hit.file.as_ref() == "app/first.rs"), + "{:?}", + enabled.hits + ); + } } diff --git a/crates/tracedecay-code-index/src/source_walk.rs b/crates/tracedecay-code-index/src/source_walk.rs index a2bb37cadaa..c32a07886e7 100644 --- a/crates/tracedecay-code-index/src/source_walk.rs +++ b/crates/tracedecay-code-index/src/source_walk.rs @@ -901,6 +901,23 @@ mod tests { ); } + #[test] + fn linked_worktree_inside_the_parent_stays_pruned_under_submodule_opt_in() { + let fixture = crate::source_walk::submodules::tests::fixture(); + let parent = fixture.path().join("parent"); + fixture_git(&parent, &["worktree", "add", "-q", "linked"]); + let policy = IndexPathPolicyV1::new(Vec::new(), Vec::new()) + .expect("empty policy") + .with_submodules(true); + let walked = walked_files(&parent, &policy); + assert!(walked.contains(&PathBuf::from("parent.rs")), "{walked:?}"); + assert!(walked.contains(&PathBuf::from("app/first.rs")), "{walked:?}"); + assert!( + !walked.iter().any(|path| path.starts_with("linked")), + "a linked worktree is not a registered submodule: {walked:?}" + ); + } + fn fixture_git(root: &std::path::Path, args: &[&str]) -> std::process::Output { let program = tracedecay_runtime_core::git::try_git_program().expect("Git program"); let mut command = std::process::Command::new(program); From b8212e890293bd5e72cabbbe5164ec4ed281a74c Mon Sep 17 00:00:00 2001 From: ScriptedAlchemy Date: Mon, 16 Nov 2026 00:50:19 -0800 Subject: [PATCH 2/2] style(code-index): format submodule boundary tests --- crates/tracedecay-code-index/src/grep_search.rs | 5 ++++- crates/tracedecay-code-index/src/source_walk.rs | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/crates/tracedecay-code-index/src/grep_search.rs b/crates/tracedecay-code-index/src/grep_search.rs index 7bb5f518881..c50fb81ed89 100644 --- a/crates/tracedecay-code-index/src/grep_search.rs +++ b/crates/tracedecay-code-index/src/grep_search.rs @@ -600,7 +600,10 @@ mod tests { disabled.hits ); assert!( - disabled.hits.iter().all(|hit| !hit.file.starts_with("app/")), + disabled + .hits + .iter() + .all(|hit| !hit.file.starts_with("app/")), "{:?}", disabled.hits ); diff --git a/crates/tracedecay-code-index/src/source_walk.rs b/crates/tracedecay-code-index/src/source_walk.rs index c32a07886e7..cbec609b107 100644 --- a/crates/tracedecay-code-index/src/source_walk.rs +++ b/crates/tracedecay-code-index/src/source_walk.rs @@ -911,7 +911,10 @@ mod tests { .with_submodules(true); let walked = walked_files(&parent, &policy); assert!(walked.contains(&PathBuf::from("parent.rs")), "{walked:?}"); - assert!(walked.contains(&PathBuf::from("app/first.rs")), "{walked:?}"); + assert!( + walked.contains(&PathBuf::from("app/first.rs")), + "{walked:?}" + ); assert!( !walked.iter().any(|path| path.starts_with("linked")), "a linked worktree is not a registered submodule: {walked:?}"