From 189d4b7192e54b1d2c7b735ac30fdadf4844f796 Mon Sep 17 00:00:00 2001 From: Craig Martin Date: Tue, 17 Nov 2026 13:28:40 -0500 Subject: [PATCH] Remove Vitest thread settings that Vitest 4 ignores VITEST_MIN_THREADS and VITEST_MAX_THREADS have had no effect since the upgrade to Vitest 4, which reads only VITEST_MAX_WORKERS. The unit-test jobs keep running with Vitest's default worker count, as they have since that upgrade. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/tests-main.yml | 2 -- .github/workflows/tests-pr.yml | 2 -- 2 files changed, 4 deletions(-) diff --git a/.github/workflows/tests-main.yml b/.github/workflows/tests-main.yml index 0b91ade100a..df577adf55c 100644 --- a/.github/workflows/tests-main.yml +++ b/.github/workflows/tests-main.yml @@ -61,8 +61,6 @@ jobs: run: pnpm vitest run ${{ env.POOL_OPTIONS }} env: POOL_OPTIONS: ${{ matrix.os == 'macos-latest' && '--pool forks' || '' }} - VITEST_MIN_THREADS: "1" - VITEST_MAX_THREADS: "4" - name: Send Slack notification on failure uses: slackapi/slack-github-action@007b2c3c751a190b6f0f040e47ed024deaa72844 # v1.23.0 if: ${{ failure() && !cancelled() }} diff --git a/.github/workflows/tests-pr.yml b/.github/workflows/tests-pr.yml index 07ce31672cf..a13000e1c5b 100644 --- a/.github/workflows/tests-pr.yml +++ b/.github/workflows/tests-pr.yml @@ -210,8 +210,6 @@ jobs: env: POOL_OPTIONS: ${{ matrix.os == 'macos-latest' && '--pool forks' || '' }} SHARD_OPTIONS: ${{ matrix.shard && format('--shard {0}', matrix.shard) || '' }} - VITEST_MIN_THREADS: "1" - VITEST_MAX_THREADS: "4" unit-tests-gate: name: "Unit tests"