Skip to content

Commit b9e018c

Browse files
committed
Fail the sbt warm layer when both attempts fail
The `[ -n "$ok" ]` check was a no-op: errexit does not apply inside the for loop, which is a non-final operand of the RUN's `&&` list, so the loop still exited 0 after two failed attempts. Exit explicitly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011f9aePV6aRxWWuVgK81qyD
1 parent 9758d4f commit b9e018c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎tests/docker/Dockerfile.sbt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ RUN set -eu \
121121
fi; \
122122
echo "warm sbt $v update failed or ran past 600 s (attempt $attempt)" >&2; \
123123
done; \
124-
[ -n "$ok" ]; \
124+
[ -n "$ok" ] || exit 1; \
125125
rm -rf "$d"; \
126126
done \
127127
&& if [ "$SBT_WARM_TOOLS" = 1 ]; then \

0 commit comments

Comments
 (0)