Skip to content

Commit 54b9b30

Browse files
committed
Trim the stable retag step and point the cache docs at the CLI reference
imagetools create already fails when the source tag is missing, so the separate inspect only added a registry round trip. The cache location is documented in cli-reference.md; the Docker guide now links there and gives only the in-image path.
1 parent 197dafd commit 54b9b30

2 files changed

Lines changed: 5 additions & 12 deletions

File tree

‎.github/workflows/docker-stable.yml‎

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,7 @@ jobs:
2525
dockerhub-username: ${{ secrets.DOCKERHUB_USERNAME }}
2626
dockerhub-token: ${{ secrets.DOCKERHUB_TOKEN }}
2727

28-
# Point stable at the image the release already published instead of
29-
# rebuilding it. A rebuild would pair that release's wheel with the
30-
# default branch's current Dockerfile, and would give users who already
31-
# pulled the release new layers to download. The retag keeps the
32-
# release's attestations.
28+
# Stable must be the release's exact digest, attestations included.
3329
- name: Tag the release image as stable
3430
env:
3531
INPUT_VERSION: ${{ inputs.version }}
@@ -38,8 +34,4 @@ jobs:
3834
echo "Error: '${INPUT_VERSION}' is not a release version such as 1.2.3"
3935
exit 1
4036
fi
41-
if ! docker buildx imagetools inspect "socketdev/cli:${INPUT_VERSION}" > /dev/null; then
42-
echo "Error: socketdev/cli:${INPUT_VERSION} is not on Docker Hub"
43-
exit 1
44-
fi
4537
docker buildx imagetools create --tag socketdev/cli:stable "socketdev/cli:${INPUT_VERSION}"

‎docs/ci-cd.md‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -539,9 +539,10 @@ docker run --rm \
539539
### Cache the reachability engine
540540

541541
With `--reach`, the CLI downloads its pinned reachability engine on first use and
542-
caches it under `$XDG_CACHE_HOME/socket/coana` (`/root/.cache/socket/coana` in the
543-
image). A new container starts with an empty cache, so without a persistent
544-
cache every run downloads the engine again. Mount a volume to keep it:
542+
caches it (see [Reachability analysis](cli-reference.md#reachability-analysis)
543+
for the location). In the image the cache is under `/root/.cache/socket`. A new
544+
container starts with an empty cache, so without a persistent cache every run
545+
downloads the engine again. Mount a volume to keep it:
545546

546547
```sh
547548
docker run --rm \

0 commit comments

Comments
 (0)