chore: rename temporary -> trial and customer -> enterprise#74
Merged
Conversation
9 tasks
iamjoemccormick
approved these changes
May 11, 2026
Member
iamjoemccormick
left a comment
iamjoemccormick
left a comment
There was a problem hiding this comment.
LGTM. Since the wire numbers don't change this is backwards and forwards compatible, and there isn't anywhere in codebases we maintain that references the string representations or outputs them someplace a user may write scripts that rely on them. Claude also verified the same:
- Wire compatibility is preserved.
CERT_TYPE_ENTERPRISE = 4(was_CUSTOMER) andCERT_TYPE_TRIAL = 5(was_TEMPORARY) keep their wire numbers, so a CLI on the old protobuf and a mgmtd on the new one (or vice versa) still interoperate at the gRPC level. No JSON/textproto serializer in this repo emits the enum name, so renaming the names is safe across both wire andbeegfs license --jsonoutput (which already emits numeric enum values viaencoding/json).
philippfalk
force-pushed
the
falk/rename-license-types
branch
from
5d14ce8 to
a46cf78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base for PRs in other repos.