From 9141925c820e83af034c341e78b733871460a8ad Mon Sep 17 00:00:00 2001 From: Vj Date: Wed, 11 Nov 2026 19:40:14 -0500 Subject: [PATCH 1/3] fix(output): preserve schema constants in approval resume hints --- internal/cli/cli_test.go | 53 ++++++++++++++++ internal/output/output.go | 25 ++++++-- internal/output/output_test.go | 70 +++++++++++++++++++++ internal/output/structured_input.go | 95 +++++++++++++++++++++++++++++ skills/a2a-cli/SKILL.md | 7 +++ 5 files changed, 245 insertions(+), 5 deletions(-) create mode 100644 internal/output/structured_input.go diff --git a/internal/cli/cli_test.go b/internal/cli/cli_test.go index e87ae96..c0b7169 100644 --- a/internal/cli/cli_test.go +++ b/internal/cli/cli_test.go @@ -833,6 +833,59 @@ func TestSend_ResumeHintForInputRequiredTask(t *testing.T) { } } +func TestSend_NumberedResumeReplyCanBeRetried(t *testing.T) { + t.Parallel() + + var mu sync.Mutex + question := 1 + server := httptest.NewServer(a2asrv.NewRESTHandler(a2asrv.NewHandler( + a2asrv.AgentExecutorFunc(func(ctx context.Context, ec *a2asrv.ExecutorContext) iter.Seq2[a2a.Event, error] { + return func(yield func(a2a.Event, error) bool) { + mu.Lock() + defer mu.Unlock() + for _, part := range ec.Message.Parts { + data, ok := part.Data().(map[string]any) + if ok && data["option"] == "once" && data["seq"] == float64(question) { + question++ + } + } + part := a2a.NewDataPart(map[string]any{ + "type": "object", + "properties": map[string]any{ + "option": map[string]any{"type": "string"}, + "seq": map[string]any{"const": question}, + }, + "required": []string{"option"}, + }) + part.Metadata = map[string]any{ + "https://github.com/a2aproject/experimental-ext-structured-input/tree/main/v1": map[string]any{"type": "input_schema"}, + } + yield(&a2a.Task{ID: ec.TaskID, ContextID: ec.ContextID, Status: a2a.TaskStatus{ + State: a2a.TaskStateInputRequired, Message: &a2a.Message{Parts: a2a.ContentParts{part}}, + }}, nil) + } + }), + ))) + t.Cleanup(server.Close) + + out := mustRunCMD(t, "send", "-e", server.URL, "--transport", "rest", "hello") + _, hint, found := strings.Cut(out, "Resume: a2a send --task-id ") + if !found { + t.Fatalf("send output = %q, want resume hint", out) + } + taskID, data, found := strings.Cut(strings.TrimSpace(hint), " --data-part '") + if !found || !strings.HasSuffix(data, "'") { + t.Fatalf("resume hint = %q, want structured reply", hint) + } + reply := strings.ReplaceAll(strings.TrimSuffix(data, "'"), "