diff --git a/src/adcp/reporting/ledger/status.py b/src/adcp/reporting/ledger/status.py index bb3b564c7..5b4710f77 100644 --- a/src/adcp/reporting/ledger/status.py +++ b/src/adcp/reporting/ledger/status.py @@ -756,18 +756,53 @@ def _obligation_coverage(obligation: ReportingObligationRecord) -> dict[str, Any def _coverage_roll_up( obligations: Sequence[ReportingObligationRecord], *, as_of: datetime ) -> dict[str, Any]: - media_buy_ids = sorted( - {item for obligation in obligations for item in obligation.media_buy_ids} + media_statuses: dict[str, set[str]] = {} + package_statuses: dict[str, set[str]] = {} + for obligation in obligations: + for media_buy_id in obligation.media_buy_ids: + media_statuses.setdefault(media_buy_id, set()).add(obligation.coverage_status) + for package_id in obligation.package_ids: + package_statuses.setdefault(package_id, set()).add(obligation.coverage_status) + + media_buy_ids = sorted(media_statuses) + package_ids = sorted(package_statuses) + fully_covered_media_buy_ids = sorted( + item for item, statuses in media_statuses.items() if statuses == {"full"} ) - package_ids = sorted({item for obligation in obligations for item in obligation.package_ids}) - statuses = {obligation.coverage_status for obligation in obligations} - status = ( - "full" - if statuses <= {"full"} - else ("partial" if statuses.intersection({"full", "partial"}) else "none") + partially_covered_media_buy_ids = sorted( + item + for item, statuses in media_statuses.items() + if statuses != {"full"} and ("full" in statuses or "partial" in statuses) ) - if "unknown" in statuses: + unknown_media_buy_ids = sorted( + item + for item, statuses in media_statuses.items() + if "unknown" in statuses and not statuses.intersection({"full", "partial"}) + ) + unsupported_media_buy_ids = sorted( + item for item, statuses in media_statuses.items() if statuses == {"none"} + ) + covered_package_ids = sorted( + item for item, statuses in package_statuses.items() if statuses == {"full"} + ) + unsupported_package_ids = sorted( + item for item, statuses in package_statuses.items() if statuses == {"none"} + ) + unknown_package_ids = sorted( + item + for item, statuses in package_statuses.items() + if statuses != {"full"} and statuses != {"none"} + ) + if len(fully_covered_media_buy_ids) == len(media_buy_ids) and len(covered_package_ids) == len( + package_ids + ): + status = "full" + elif fully_covered_media_buy_ids or partially_covered_media_buy_ids or covered_package_ids: + status = "partial" + elif unknown_media_buy_ids or unknown_package_ids: status = "unknown" + else: + status = "none" evaluated = ( max(obligation.scope_resolved_at for obligation in obligations) if obligations else as_of ) @@ -775,14 +810,14 @@ def _coverage_roll_up( "status": status, "evaluated_at": _iso(evaluated), "media_buy_ids": media_buy_ids, - "fully_covered_media_buy_ids": media_buy_ids if status == "full" else [], - "partially_covered_media_buy_ids": [], - "unsupported_media_buy_ids": [], - "unknown_media_buy_ids": [], + "fully_covered_media_buy_ids": fully_covered_media_buy_ids, + "partially_covered_media_buy_ids": partially_covered_media_buy_ids, + "unsupported_media_buy_ids": unsupported_media_buy_ids, + "unknown_media_buy_ids": unknown_media_buy_ids, "package_ids": package_ids, - "covered_package_ids": package_ids if status == "full" else [], - "unsupported_package_ids": [], - "unknown_package_ids": [], + "covered_package_ids": covered_package_ids, + "unsupported_package_ids": unsupported_package_ids, + "unknown_package_ids": unknown_package_ids, "limitations": [], } diff --git a/tests/test_reporting_ledger.py b/tests/test_reporting_ledger.py index e6dc209e4..cc7f9d91e 100644 --- a/tests/test_reporting_ledger.py +++ b/tests/test_reporting_ledger.py @@ -36,6 +36,8 @@ revision_content_sha256, ) from adcp.reporting.ledger import ReportingStatusCaller as OwnershipCaller +from adcp.reporting.ledger.status import _coverage_roll_up, _obligation_coverage +from adcp.types import GetReportingStatusResponse ACCOUNT = "acct_1" CALLER = ReportingStatusCaller(account_id=ACCOUNT, consumer_id="buyer_1") @@ -637,6 +639,103 @@ async def test_summary_escalates_after_the_automated_recovery_window() -> None: assert payload["issues"][0]["recommended_action"] == "contact_seller" +def test_unknown_coverage_partitions_exact_buys_without_inventing_packages() -> None: + configuration = _configuration(media_buy_ids=("mb_2", "mb_1")) + obligation = _obligation(configuration, coverage_status="unknown") + + period = _obligation_coverage(obligation) + summary = _coverage_roll_up((obligation,), as_of=obligation.period.end) + for coverage in (period, summary): + assert coverage["status"] == "unknown" + assert coverage["media_buy_ids"] == coverage["unknown_media_buy_ids"] + assert set(coverage["unknown_media_buy_ids"]) == {"mb_1", "mb_2"} + assert coverage["fully_covered_media_buy_ids"] == [] + assert coverage["package_ids"] == [] + assert coverage["covered_package_ids"] == [] + assert coverage["unknown_package_ids"] == [] + + +def test_summary_partitions_full_and_unknown_buys_across_periods() -> None: + configuration = _configuration(media_buy_ids=("mb_full", "mb_unknown")) + full = _obligation(configuration, ordinal=1, media_buy_ids=("mb_full",)) + unknown = _obligation( + configuration, ordinal=2, media_buy_ids=("mb_unknown",), coverage_status="unknown" + ) + + coverage = _coverage_roll_up((full, unknown), as_of=unknown.period.end) + + assert coverage["status"] == "partial" + assert coverage["media_buy_ids"] == ["mb_full", "mb_unknown"] + assert coverage["fully_covered_media_buy_ids"] == ["mb_full"] + assert coverage["partially_covered_media_buy_ids"] == [] + assert coverage["unsupported_media_buy_ids"] == [] + assert coverage["unknown_media_buy_ids"] == ["mb_unknown"] + assert coverage["package_ids"] == [] + + +def test_summary_classifies_buy_with_full_and_unknown_periods_as_partial() -> None: + configuration = _configuration(media_buy_ids=("mb_shared",)) + full = _obligation(configuration, ordinal=1) + unknown = _obligation(configuration, ordinal=2, coverage_status="unknown") + + coverage = _coverage_roll_up((full, unknown), as_of=unknown.period.end) + + assert coverage["status"] == "partial" + assert coverage["media_buy_ids"] == ["mb_shared"] + assert coverage["fully_covered_media_buy_ids"] == [] + assert coverage["partially_covered_media_buy_ids"] == ["mb_shared"] + assert coverage["unknown_media_buy_ids"] == [] + + +async def test_public_status_summary_partitions_full_and_unknown_periods() -> None: + store = InMemoryReportingLedgerStore(clock=lambda: datetime(2026, 9, 30, tzinfo=timezone.utc)) + configuration = _configuration(media_buy_ids=("mb_full", "mb_unknown")) + await store.put_configuration(configuration) + await store.commit_obligation(_obligation(configuration, ordinal=1, media_buy_ids=("mb_full",))) + await store.commit_obligation( + _obligation( + configuration, + ordinal=2, + media_buy_ids=("mb_unknown",), + coverage_status="unknown", + ) + ) + + payload = await ReportingStatusHandler(store).handle({"view": "summary"}, caller=CALLER) + GetReportingStatusResponse.model_validate(payload) + coverage = payload["coverage"] + assert coverage["status"] == "partial" + assert coverage["media_buy_ids"] == ["mb_full", "mb_unknown"] + assert coverage["fully_covered_media_buy_ids"] == ["mb_full"] + assert coverage["partially_covered_media_buy_ids"] == [] + assert coverage["unsupported_media_buy_ids"] == [] + assert coverage["unknown_media_buy_ids"] == ["mb_unknown"] + assert coverage["package_ids"] == [] + + +def test_proven_empty_revision_keeps_full_coverage_and_complete_health() -> None: + configuration = _configuration() + obligation = _obligation(configuration) + revision, rows = _revision(obligation, rows=[], control_totals=(("impressions", "0"),)) + assert rows == [] + projection = project_obligation_health( + obligation, + [revision], + ledger_as_of=obligation.automated_recovery_deadline_at + timedelta(days=1), + scope_closed=True, + ) + + assert projection.health == "complete" + for coverage in ( + _obligation_coverage(obligation), + _coverage_roll_up((obligation,), as_of=obligation.period.end), + ): + assert coverage["status"] == "full" + assert coverage["fully_covered_media_buy_ids"] == ["mb_1"] + assert coverage["unknown_media_buy_ids"] == [] + assert coverage["package_ids"] == [] + + async def test_periods_view_paginates_one_snapshot() -> None: store, obligation = await _seeded() revision, rows = _revision(obligation)