diff --git a/.github/workflows/changeset-check.yml b/.github/workflows/changeset-check.yml index 660d11b63..f49e1be45 100644 --- a/.github/workflows/changeset-check.yml +++ b/.github/workflows/changeset-check.yml @@ -32,7 +32,7 @@ jobs: changed_files="$(git diff --name-only "origin/${BASE_REF}...HEAD")" package_changes="$( printf '%s\n' "$changed_files" | - grep -Ev '^(\.changeset/pre\.json|CHANGELOG\.md|package(-lock)?\.json|packages/[^/]+/(CHANGELOG\.md|package\.json)|src/lib/version\.ts|docs/(llms\.txt|TYPE-SUMMARY\.md)|\.github/workflows/(changeset-check|ci|release)\.yml)$' || + grep -Ev '^(\.changeset/pre\.json|CHANGELOG\.md|package(-lock)?\.json|packages/[^/]+/(CHANGELOG\.md|package\.json)|src/lib/version\.ts|docs/(llms\.txt|TYPE-SUMMARY\.md)|\.github/workflows/(changeset-check|ci|codeql|interop-python|release)\.yml)$' || true )" diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7b71caefc..74ff35867 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,9 +2,9 @@ name: CI/CD Pipeline on: push: - branches: [main] + branches: [main, 13.x] pull_request: - branches: [main] + branches: [main, 13.x] permissions: contents: read @@ -41,6 +41,71 @@ jobs: - name: Lint GitHub Actions workflows run: npm run lint:workflows + # These exact event/path expectations are deliberately 13.x-local. Adapt + # them when forward-merging or adding workflow_dispatch/path filters. + - name: Verify stable maintenance workflow coverage + run: | + node - <<'NODE' + const assert = require('node:assert/strict'); + const fs = require('node:fs'); + const { parse } = require('yaml'); + + const readWorkflow = name => + parse(fs.readFileSync(`.github/workflows/${name}.yml`, 'utf8')); + const expectedBranches = ['13.x', 'main']; + const assertEvents = (workflow, expected, name) => { + assert.deepEqual( + Object.keys(workflow.on ?? {}).sort(), + [...expected].sort(), + `${name} must expose only its intended events` + ); + }; + const assertBranches = (workflow, event, name) => { + const trigger = workflow.on?.[event]; + assert.deepEqual( + Object.keys(trigger ?? {}).sort(), + ['branches'], + `${name} ${event} must not add path or ignore filters` + ); + assert.deepEqual( + [...(trigger?.branches ?? [])].sort(), + expectedBranches, + `${name} ${event} branches must be exactly main and 13.x` + ); + }; + + const ci = readWorkflow('ci'); + assertEvents(ci, ['push', 'pull_request'], 'ci.yml'); + assertBranches(ci, 'push', 'ci.yml'); + assertBranches(ci, 'pull_request', 'ci.yml'); + + const changesetCheck = readWorkflow('changeset-check'); + assertEvents(changesetCheck, ['pull_request'], 'changeset-check.yml'); + assertBranches(changesetCheck, 'pull_request', 'changeset-check.yml'); + + const codeql = readWorkflow('codeql'); + assertEvents(codeql, ['push', 'pull_request', 'schedule'], 'codeql.yml'); + assertBranches(codeql, 'push', 'codeql.yml'); + assertBranches(codeql, 'pull_request', 'codeql.yml'); + + const interop = readWorkflow('interop-python'); + assertEvents( + interop, + ['pull_request', 'workflow_dispatch', 'workflow_call'], + 'interop-python.yml' + ); + assertBranches(interop, 'pull_request', 'interop-python.yml'); + assert.equal( + interop.on?.push, + undefined, + 'interop-python.yml must rely on release.yml for push events' + ); + + const release = readWorkflow('release'); + assertEvents(release, ['push'], 'release.yml'); + assertBranches(release, 'push', 'release.yml'); + NODE + - name: Sync schemas from AdCP run: npm run sync-schemas:all diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 992c8b302..97d33441f 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -13,9 +13,9 @@ name: "CodeQL Advanced" on: push: - branches: [ "main" ] + branches: [ "main", "13.x" ] pull_request: - branches: [ "main" ] + branches: [ "main", "13.x" ] schedule: - cron: '37 3 * * 2' diff --git a/.github/workflows/interop-python.yml b/.github/workflows/interop-python.yml index 6d79e9ba6..0721c2424 100644 --- a/.github/workflows/interop-python.yml +++ b/.github/workflows/interop-python.yml @@ -2,7 +2,7 @@ name: Reference Seller Interop on: pull_request: - branches: [main] + branches: [main, 13.x] workflow_dispatch: inputs: python_ref: