From 97057931798034e9ed57a6f4160b7d01f635a5ac Mon Sep 17 00:00:00 2001 From: Brian O'Kelley Date: Mon, 14 Sep 2026 11:17:23 +0000 Subject: [PATCH] fix(release): fail closed on beta artifact deletions --- scripts/check-immutable-release-artifacts.cjs | 14 ------ tests/immutable-release-artifacts.test.cjs | 50 ++++++++++++++++--- 2 files changed, 42 insertions(+), 22 deletions(-) diff --git a/scripts/check-immutable-release-artifacts.cjs b/scripts/check-immutable-release-artifacts.cjs index 80637f20e64..3abdc7e6739 100644 --- a/scripts/check-immutable-release-artifacts.cjs +++ b/scripts/check-immutable-release-artifacts.cjs @@ -58,17 +58,6 @@ function parseNameStatus(output) { }); } -const RETIRED_PRERELEASE_RE = /-beta\.\d+$/; - -/** - * Beta checkpoints are superseded once a release candidate exists. Deleting a - * whole beta artifact tree is allowed so the repository and runtime image can - * retire it; editing it in place, or deleting rc/stable artifacts, still fails. - */ -function isRetiredPrereleaseDeletion(status, version) { - return String(status).startsWith('D') && RETIRED_PRERELEASE_RE.test(version); -} - function findImmutableArtifactViolations(changes, hasPathAtBase, isReleasedVersion = () => true) { const violations = []; @@ -80,7 +69,6 @@ function findImmutableArtifactViolations(changes, hasPathAtBase, isReleasedVersi const existedAtBase = artifact.probePaths.some(hasPathAtBase); if (!existedAtBase) continue; if (!isReleasedVersion(artifact.version)) continue; - if (isRetiredPrereleaseDeletion(change.status, artifact.version)) continue; violations.push({ status: change.status, @@ -131,7 +119,6 @@ function formatViolationMessage(violations) { ...violations.map(v => ` - ${v.status} ${v.path}`), '', 'Do not patch existing versioned dist artifacts in-place.', - 'Only whole-tree deletions of superseded beta checkpoints are permitted.', 'Change the source files, add a changeset, and ship a new versioned artifact through Version Packages (`npm run version`).', 'Mutable development outputs such as dist/*/latest are allowed; existing dist/*/ releases are not.', ]; @@ -163,7 +150,6 @@ if (require.main === module) { module.exports = { findImmutableArtifactViolations, - isRetiredPrereleaseDeletion, formatViolationMessage, parseImmutableArtifactPath, parseNameStatus, diff --git a/tests/immutable-release-artifacts.test.cjs b/tests/immutable-release-artifacts.test.cjs index 81504de7b4b..918f19d7a3c 100644 --- a/tests/immutable-release-artifacts.test.cjs +++ b/tests/immutable-release-artifacts.test.cjs @@ -15,6 +15,16 @@ function hasBasePath(paths) { assert.deepStrictEqual(parseImmutableArtifactPath('dist/compliance/latest/index.json'), null); +assert.deepStrictEqual( + parseImmutableArtifactPath('.\\dist\\schemas\\3.2.0-beta.11\\index.json'), + { + kind: 'schemas', + version: '3.2.0-beta.11', + releaseRoot: 'dist/schemas/3.2.0-beta.11', + probePaths: ['dist/schemas/3.2.0-beta.11'], + } +); + assert.deepStrictEqual( parseImmutableArtifactPath('dist/compliance/3.0.14/universal/idempotency.yaml'), { @@ -26,10 +36,14 @@ assert.deepStrictEqual( ); assert.deepStrictEqual( - parseNameStatus('M\tdist/compliance/3.0.14/index.json\nR100\tdist/docs/3.0.14/a.md\tdist/docs/3.0.14/b.md\n'), + parseNameStatus( + 'M\tdist/compliance/3.0.14/index.json\nD\tdist/schemas/3.0.14/index.json\nR100\tdist/docs/3.0.14/a.md\tdist/docs/3.0.14/b.md\nC100\tsource.tgz\tdist/protocol/3.0.14.tgz\n' + ), [ { status: 'M', paths: ['dist/compliance/3.0.14/index.json'] }, + { status: 'D', paths: ['dist/schemas/3.0.14/index.json'] }, { status: 'R100', paths: ['dist/docs/3.0.14/a.md', 'dist/docs/3.0.14/b.md'] }, + { status: 'C100', paths: ['source.tgz', 'dist/protocol/3.0.14.tgz'] }, ] ); @@ -84,14 +98,34 @@ violations = findImmutableArtifactViolations( assert.deepStrictEqual(violations, [], 'Deleting artifacts for an untagged aborted release is allowed'); violations = findImmutableArtifactViolations( - [ - { status: 'D', paths: ['dist/schemas/3.2.0-beta.3/index.json'] }, - { status: 'D', paths: ['dist/compliance/3.2.0-beta.3/index.json'] }, - { status: 'D', paths: ['dist/protocol/3.2.0-beta.3.tgz'] }, - ], - hasBasePath(['dist/schemas/3.2.0-beta.3', 'dist/compliance/3.2.0-beta.3', 'dist/protocol/3.2.0-beta.3.tgz']) + [{ status: 'D', paths: ['dist/schemas/3.1.1/index.json'] }], + hasBasePath(['dist/schemas/3.1.1']) +); +assert.strictEqual(violations.length, 1, 'Deleting a tagged stable artifact must fail'); + +violations = findImmutableArtifactViolations( + [{ status: 'D', paths: ['dist/schemas/3.2.0-beta.11/index.json'] }], + hasBasePath(['dist/schemas/3.2.0-beta.11']) +); +assert.strictEqual(violations.length, 1, 'Deleting one file from a tagged beta schema must fail'); + +violations = findImmutableArtifactViolations( + [{ status: 'D', paths: ['dist/compliance/3.2.0-beta.11/index.json'] }], + hasBasePath(['dist/compliance/3.2.0-beta.11']) +); +assert.strictEqual(violations.length, 1, 'Deleting one file from tagged beta compliance must fail'); + +violations = findImmutableArtifactViolations( + [{ status: 'D', paths: ['dist/protocol/3.2.0-beta.11.tgz'] }], + hasBasePath(['dist/protocol/3.2.0-beta.11.tgz']) +); +assert.strictEqual(violations.length, 1, 'Deleting a tagged beta protocol tarball must fail'); + +violations = findImmutableArtifactViolations( + [{ status: 'D', paths: ['dist/protocol/3.2.0-beta.11.tgz.sig'] }], + hasBasePath(['dist/protocol/3.2.0-beta.11.tgz']) ); -assert.deepStrictEqual(violations, [], 'Retiring a tagged beta checkpoint by deleting its artifacts is allowed'); +assert.strictEqual(violations.length, 1, 'Deleting a tagged beta protocol sidecar must fail'); violations = findImmutableArtifactViolations( [{ status: 'D', paths: ['dist/schemas/3.2.0-rc.1/index.json'] }],