From 24339dc0eecec91f39bd61452ff55690f5c058fd Mon Sep 17 00:00:00 2001 From: DoDiODev Date: Tue, 6 Oct 2026 14:50:45 +0200 Subject: [PATCH 1/2] fix(ci): run unit and e2e tests when backend/go.mod, go.sum or Makefile change The pull_request paths filters of test.yml and test-e2e.yml list 'go.mod', 'go.sum' and 'Makefile' without a directory prefix. GitHub matches these patterns against the repository root only, so changes to backend/go.mod, backend/go.sum or backend/Makefile never trigger the unit-test and e2e jobs. Dependabot gomod PRs (e.g. #9192) therefore become mergeable without a single compile or test run, and the go.mod tidiness guard added in #9179 is skipped exactly where it matters. Prefix the patterns with '**/' so they match at any depth, including the repository root. --- .github/workflows/test-e2e.yml | 6 +++--- .github/workflows/test.yml | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test-e2e.yml b/.github/workflows/test-e2e.yml index 8b0b4ea589a..5c8d89a3b1c 100644 --- a/.github/workflows/test-e2e.yml +++ b/.github/workflows/test-e2e.yml @@ -27,9 +27,9 @@ on: - '**.py' - '**.toml' - '**.sh' - - "Makefile" - - "go.mod" - - "go.sum" + - "**/Makefile" + - "**/go.mod" + - "**/go.sum" - ".github/workflows/*.yml" - "test/**" - "e2e/**" diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1e2542b2c4f..8c94eb29db3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -27,9 +27,9 @@ on: - '**.py' - '**.toml' - '**.sh' - - 'Makefile' - - 'go.mod' - - 'go.sum' + - '**/Makefile' + - '**/go.mod' + - '**/go.sum' - '.github/workflows/*.yml' - 'test/**' schedule: From 3128c628281cd0a3a33ad88a174ed3ead4f86e72 Mon Sep 17 00:00:00 2001 From: DoDiODev Date: Tue, 6 Oct 2026 14:51:25 +0200 Subject: [PATCH 2/2] build(lint): tolerate the aws-sdk-go v1 deprecation in the kiro plugin aws-sdk-go v1 reached end-of-support on 2025-07-31. Its final release, v1.55.8, marks every package as deprecated, so staticcheck reports SA1019 for each import in plugins/kiro. This turns the lint job red for the Dependabot go-minor-patch group (#9192) and for every future gomod update, although nothing in the code changed. Exclude exactly this finding (SA1019 for aws-sdk-go, only under plugins/kiro/) instead of pinning the dependency or adding nolint comments, so the remaining technical debt stays visible in one place. The exclusion is meant to be removed once the plugin is migrated to aws-sdk-go-v2 (tracked in a separate issue). --- backend/.golangci.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/backend/.golangci.yaml b/backend/.golangci.yaml index fa4042b6bbb..70902b9081f 100644 --- a/backend/.golangci.yaml +++ b/backend/.golangci.yaml @@ -239,6 +239,13 @@ linters: - linters: - revive path: plugins/([^hc].*|.[^eo].*|..[^lr].*|...[^pe].*|....[^e].*|.....[^r].*) + # aws-sdk-go v1 is end-of-support and its last release marks every + # package as deprecated. Tolerate that only for the kiro plugin until it + # is migrated to aws-sdk-go-v2; remove this rule afterwards. + - linters: + - staticcheck + path: plugins/kiro/ + text: 'SA1019: "github.com/aws/aws-sdk-go/' paths: - third_party$ - builtin$