From d9eb79e2c3265f0aa7a5ac289c4f4bfd670cb397 Mon Sep 17 00:00:00 2001 From: Rico Huijbers Date: Mon, 4 May 2026 16:06:21 +0200 Subject: [PATCH] fix: bundled dependencies cause problems in consuming packages Sister PR to https://github.com/aws/aws-cdk/pull/37726. If `npm` sees the same dependency bundled at multiple levels inside a bundled dependency, installation will fail. Remove bundled dependencies here; since this package is not a jsii package, they don't need to be bundled anyway, and they can just be installed by NPM. --- .projenrc.ts | 5 ++++- .../@aws-cdk/cloud-assembly-api/.projen/deps.json | 12 ++++++------ packages/@aws-cdk/cloud-assembly-api/package.json | 7 ------- 3 files changed, 10 insertions(+), 14 deletions(-) diff --git a/.projenrc.ts b/.projenrc.ts index 60cc99772..8a64bf6f7 100644 --- a/.projenrc.ts +++ b/.projenrc.ts @@ -572,10 +572,13 @@ const cloudAssemblyApi = configureProject( name: '@aws-cdk/cloud-assembly-api', description: 'API for working with Cloud Assemblies', srcdir: 'lib', - bundledDeps: ['jsonschema@~1.4.1', 'semver'], devDeps: [ cloudAssemblySchema.customizeReference({ versionType: 'exact' }), ], + deps: [ + 'jsonschema@~1.4.1', + 'semver', + ], peerDeps: [ cloudAssemblySchema.customizeReference({ versionType: 'any-future' }), ], diff --git a/packages/@aws-cdk/cloud-assembly-api/.projen/deps.json b/packages/@aws-cdk/cloud-assembly-api/.projen/deps.json index 172b7c3b3..b14710ff1 100644 --- a/packages/@aws-cdk/cloud-assembly-api/.projen/deps.json +++ b/packages/@aws-cdk/cloud-assembly-api/.projen/deps.json @@ -106,18 +106,18 @@ "version": "5.9", "type": "build" }, + { + "name": "@aws-cdk/cloud-assembly-schema", + "type": "peer" + }, { "name": "jsonschema", "version": "~1.4.1", - "type": "bundled" + "type": "runtime" }, { "name": "semver", - "type": "bundled" - }, - { - "name": "@aws-cdk/cloud-assembly-schema", - "type": "peer" + "type": "runtime" } ], "//": "~~ Generated by projen. To modify, edit .projenrc.js and run \"yarn projen\"." diff --git a/packages/@aws-cdk/cloud-assembly-api/package.json b/packages/@aws-cdk/cloud-assembly-api/package.json index aa627e2fb..89b3febcc 100644 --- a/packages/@aws-cdk/cloud-assembly-api/package.json +++ b/packages/@aws-cdk/cloud-assembly-api/package.json @@ -63,10 +63,6 @@ "jsonschema": "~1.4.1", "semver": "^7.7.4" }, - "bundledDependencies": [ - "jsonschema", - "semver" - ], "keywords": [ "aws", "cdk" @@ -90,8 +86,5 @@ "version": "0.0.0", "packageManager": "yarn@4.13.0", "types": "lib/index.d.ts", - "installConfig": { - "hoistingLimits": "workspaces" - }, "//": "~~ Generated by projen. To modify, edit .projenrc.js and run \"yarn projen\"." }