-
|
Hi guys, am I the only one here getting a notification nagging I can't mute? 
I need to know if this is intended or an issue before opening one.. Version: 0.22.79.0 |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 2 replies
-
|
This was an unintended side-effect that resulted from fixing something else. I noticed this as well and planned to fix it soon. But I've bumped this up in priority and created an issue for it: #136 In case you wanted more info. When Wayland asks for remote control permission, and you check the option to "allow restoring on future sessions", it provides a one-time use token that bypasses the permission check on the next session. Previously, ControlR was only checking to see if we had a restore token. If it existed at all, we considered remote control permissions as being granted. But it wasn't actually checking if the token was still valid. If I manually modified it, everywhere in the UI and remote control flow considered permissions as being granted already. So as a defensive step, I added a pre-flight "probing" check to actually test if the token will work. Unfortunately, I didn't realize until after release that the background check (responsible for showing intermittent toast notifications of "Hey, ControlR needs permissions") was causing these notifications from Wayland. As a workaround, I'll change the background checks to only check for the existence of the token. Actually testing the validity of the token will only occur during remote control pre-flight, where the remote control page shows if we need to request access from the user first. |
Beta Was this translation helpful? Give feedback.
-
|
Note: Also, as far as I can tell from the docs (https://flatpak.github.io/xdg-desktop-portal/docs/api-reference.html), there isn't another way to test "is this restore token valid". |
Beta Was this translation helpful? Give feedback.
-
|
oh got it! thanks, it's very good to know. I thought maybe something went wrong with my fedora 43->44 upgrade, this rules it out :) |
Beta Was this translation helpful? Give feedback.
This was an unintended side-effect that resulted from fixing something else. I noticed this as well and planned to fix it soon. But I've bumped this up in priority and created an issue for it: #136
In case you wanted more info. When Wayland asks for remote control permission, and you check the option to "allow restoring on future sessions", it provides a one-time use token that bypasses the permission check on the next session.
Previously, ControlR was only checking to see if we had a restore token. If it existed at all, we considered remote control permissions as being granted. But it wasn't actually checking if the token was still valid. If I manually modified it, everywhere in the UI a…