From f2c1b75b06472d1cb34fc22e9ba4c55719dcb3ad Mon Sep 17 00:00:00 2001 From: Josh Friend Date: Fri, 15 May 2026 20:42:15 -0400 Subject: [PATCH] fix: correct job_duration metric unit from "{ms}" to "s" The metric records elapsed.Seconds() but the unit was "{ms}" (a dimensionless annotation, not milliseconds). Fix to "s" to match the recorded value and OTel conventions. --- internal/jobscheduler/metrics.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/jobscheduler/metrics.go b/internal/jobscheduler/metrics.go index 5a627f1..a3705e4 100644 --- a/internal/jobscheduler/metrics.go +++ b/internal/jobscheduler/metrics.go @@ -22,6 +22,6 @@ func newSchedulerMetrics() *schedulerMetrics { activeWorkers: metrics.NewMetric[metric.Int64Gauge](meter, "cachew.scheduler.active_workers", "{workers}", "Number of workers currently executing jobs"), activeClones: metrics.NewMetric[metric.Int64Gauge](meter, "cachew.scheduler.active_clones", "{jobs}", "Number of clone jobs currently executing"), jobsTotal: metrics.NewMetric[metric.Int64Counter](meter, "cachew.scheduler.jobs_total", "{jobs}", "Total number of completed scheduler jobs"), - jobDuration: metrics.NewMetric[metric.Float64Histogram](meter, "cachew.scheduler.job_duration", "{ms}", "Histogram of job durations"), + jobDuration: metrics.NewMetric[metric.Float64Histogram](meter, "cachew.scheduler.job_duration", "s", "Histogram of job durations in seconds"), } }