From d9838c920f44d2432cbc3f5f633f3e7bfcab62a0 Mon Sep 17 00:00:00 2001 From: Szymon Chmal Date: Mon, 16 Nov 2026 22:17:12 +0100 Subject: [PATCH 1/2] =?UTF-8?q?test:=20reproduce=20#1628=20=E2=80=94=20the?= =?UTF-8?q?=20drain-and-restart=20test=20asks=20for=20Pixel-B=20before=20t?= =?UTF-8?q?he=20reconnected=20worker's=20catalog=20lands?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/daemon/gateway-fleet.e2e.test.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/daemon/gateway-fleet.e2e.test.ts b/src/daemon/gateway-fleet.e2e.test.ts index 975b7ece5..ce68e6442 100644 --- a/src/daemon/gateway-fleet.e2e.test.ts +++ b/src/daemon/gateway-fleet.e2e.test.ts @@ -227,6 +227,8 @@ describe("gateway fleet smoke (ADR 0005 §35)", () => { readonly npm?: NpmCli; /** why: a worker that runs a real command runs it in its lease folder, which has to exist on disk. */ readonly realFilesystem?: boolean; + /** why: holds the gateway's first catalog read open, so a view shows `connected` before it lists the worker's model. */ + readonly catalogLatencyMs?: number; }): Promise<{ daemon: DaemonServer; filesystem: Filesystem; directory: string }> { const directory = options.existing?.directory ?? @@ -247,6 +249,9 @@ describe("gateway fleet smoke (ADR 0005 §35)", () => { }), clock: new SystemClock(), knownModels: [options.model], + ...(options.catalogLatencyMs === undefined + ? {} + : { latencyMs: { listCatalog: options.catalogLatencyMs } }), platform: "android", }); options.onDriver?.(driver); @@ -662,6 +667,8 @@ describe("gateway fleet smoke (ADR 0005 §35)", () => { stdout: "hello-from-b", gatewayUrl: restartGatewayUrl(), existing: { directory: workerB.directory, filesystem: workerB.filesystem }, + // why: #1628: the catalog lands after `connected` and `drained`; held here so the wait below must cover it on every run. + catalogLatencyMs: 1_000, }); await vi.waitFor( async () => { From 5a92f33fd5edd7423bf717280bd504a3cb494507 Mon Sep 17 00:00:00 2001 From: Szymon Chmal Date: Mon, 16 Nov 2026 22:20:48 +0100 Subject: [PATCH 2/2] fix(test): the restart wait covers worker-b's catalog before asking for Pixel-B (#1628) --- src/daemon/gateway-fleet.e2e.test.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/daemon/gateway-fleet.e2e.test.ts b/src/daemon/gateway-fleet.e2e.test.ts index ce68e6442..feaab82e0 100644 --- a/src/daemon/gateway-fleet.e2e.test.ts +++ b/src/daemon/gateway-fleet.e2e.test.ts @@ -676,6 +676,8 @@ describe("gateway fleet smoke (ADR 0005 §35)", () => { const view = workers.find((worker) => worker.id === workerBId); expect(view?.connection).toBe("connected"); expect(view?.drained).toBe(true); + // why: `connected` and `drained` show before the catalog read lands; a fresh gateway has no older catalog, so routing answers UNKNOWN_MODEL until then. + expect(view?.catalog?.some((entry) => entry.models.includes("Pixel-B"))).toBe(true); }, { timeout: 15_000 }, );