tests: expect warning on azure pro images. avoid client.destroy#6872
Draft
blackboxsw wants to merge 1 commit into
Draft
tests: expect warning on azure pro images. avoid client.destroy#6872blackboxsw wants to merge 1 commit into
blackboxsw wants to merge 1 commit into
Conversation
Member
|
GitHub can't show me the files currently, but from the description I don't see how this is a pro-specific issue. Can you please elaborate? |
….destroy Avoid client.destroy within the cloud_session.launch context manager as it already performs cloud.destroy on context exit which calls instance.destroy. This avoids the following error seen by pycloudlib on Azure instances: <pycloudlib.azure.instance.AzureInstance object at .... @Property def id(self): """Return instance id.""" return self._instance["vm"].id ^^^^^^^^^^^^^^^^^^^^ TypeError: 'NoneType' object is not subscriptable Additionally, some Azure instance launches encounter intemittent warning reaching IMDS on first attempt. Avoid failing integration tests when encountering a single warning about IMDS access. If multiple retries are required to reach Azure IMDS, treat this as an error.
ad428d1 to
c407dc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix integration test errors seen on Azure UbuntuPro testing seen during SRU review of 26.1.
Ignore intermittent warning about single retry seen on some Azure Pro images during first attempt to contact IMDS during first boot. This issue seems to occur most frequently on Azure marketplace Pro images but may not be limited to Pro images.
Avoid client.destroy when our integration test is within cloud_session.launch context manager because that tear down is performed by the context manager.
Proposed Commit Message
Additional Context
Test Steps
Merge type