Feature - Schemata Typescript Edition [wip]#5
Draft
jmurth1234 wants to merge 6 commits into
Draft
Conversation
Convert remaining 6 JS source files and 12 JS test files to TypeScript, standardize imports to ES6 style throughout, and add tsconfig.json for type-checking. All 101 tests pass with zero tsc errors. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to rewrite schemata using typescript, with all the benefits that gives us including type inference of:
All without having to define any additional interfaces
There are minimal API changes, the use of schemata in a project should be the same as it is now.
The main difference is how schemata instances and schemata arrays are handled. Previously, these were standard JS Objects. Now, in order to infer their type when used in a schema, they are now passed as functions.
Things still left to do: