Skip to content

[fix] Recognize full-index git patch format correctly#45

Merged
uilianries merged 3 commits into
conan-io:masterfrom
uilianries:fix/git-format-check
Oct 1, 2025
Merged

[fix] Recognize full-index git patch format correctly#45
uilianries merged 3 commits into
conan-io:masterfrom
uilianries:fix/git-format-check

Conversation

@uilianries
Copy link
Copy Markdown
Member

@uilianries uilianries commented Oct 1, 2025

Description of your Pull Request

Based on the PR #39, but adding a test to validate the reported bug and improved the regex to cover when a file is removed as well.

fixes #38
closes #39

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've tested locally that my code works.
  • I've added relevant tests to verify that my code works.

Signed-off-by: Uilian Ries <uilianr@jfrog.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 1, 2025

CLA assistant check
All committers have signed the CLA.

@uilianries
Copy link
Copy Markdown
Member Author

The first check failed as expected, proving the reported issue #38: https://github.com/conan-io/python-patch-ng/actions/runs/18158173193/job/51682709561?pr=45#step:4:46

Signed-off-by: Uilian Ries <uilianr@jfrog.com>
@uilianries uilianries marked this pull request as ready for review October 1, 2025 09:48
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
@uilianries uilianries merged commit 2e39f4f into conan-io:master Oct 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] GIT format patches detection is incorrect

2 participants