From e9740aa79580a7df6b657419ad7142467ae1cf84 Mon Sep 17 00:00:00 2001 From: dahai80 <121743945@qq.com> Date: Sat, 14 Nov 2026 21:03:50 +0800 Subject: [PATCH] fix(cli): team send requires --from member per kernel contract (refs #268) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Live e2e against agent-studio v0.16.1 (upstream #710 fixed) exposed two defects in cmdSend: 1. Default sender "lead" is not an entity — fusion-harness team_runtime.send validates BOTH sender and recipient against the declared member list, so every default send returned "unknown member: lead". --from is now required. 2. The --from flag parser did not strip the flag tokens from the message body ("msg --from bob" delivered the flag text). Fake UDS daemon in tests now mirrors the kernel member-validation semantics (previous fixture accepted any sender — test passed for the wrong reason). 3 new cases: --from delivery, missing --from rejection, flag-leak regression. Verified: 10/10 team tests, 1272 unit pass, tsc/biome clean, live daemon flow register/duplicate-reject/send/task/status/disband green. --- src/cli/handlers/team.ts | 23 ++++++++++++++------ tests/cli/team.test.ts | 47 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 62 insertions(+), 8 deletions(-) diff --git a/src/cli/handlers/team.ts b/src/cli/handlers/team.ts index 8d9c241d..9ce55b25 100644 --- a/src/cli/handlers/team.ts +++ b/src/cli/handlers/team.ts @@ -6,7 +6,7 @@ // team register register team + initial tasks // team status [team] board state (or list all teams) // team task add add a task (--detail, --assignee) -// team send <team> <member> <msg> mailbox send (--from, default "lead") +// team send <team> <member> <msg> mailbox send (--from SENDER required) // team disband <team> disband (--keep-inboxes to skip cleanup) import { cwd } from "node:process"; import { @@ -23,7 +23,7 @@ subcommands: register <manifest.json> register team + initial tasks from manifest status [team] show one team's board (or list all teams) task add <team> <title> add a task (--detail TEXT, --assignee MEMBER) - send <team> <member> <message> send a mailbox message (--from SENDER, default "lead") + send <team> <member> <message> send a mailbox message (--from SENDER, required; sender must be a declared member) disband <team> disband the team (--keep-inboxes)`; // ok()/fail() terminate via an ExitSignal instead of calling process.exit @@ -167,17 +167,26 @@ async function cmdSend( args: string[], ): Promise<never> { const [team, member] = [args[0], args[1]]; - const message = args.slice(2).join(" ").trim(); - if (!team || !member || !message) { + if (!team || !member) { fail(USAGE); } - let from = "lead"; - for (let i = 0; i < args.length; i += 1) { + // Kernel contract (fusion-harness team_runtime.send): BOTH sender and + // recipient must be declared team members — "lead" is not an entity. + // --from is therefore required and must name a manifest member. + let from = ""; + const bodyTokens: string[] = []; + for (let i = 2; i < args.length; i += 1) { if (args[i] === "--from" && args[i + 1]) { - from = args[i + 1] ?? "lead"; + from = args[i + 1] ?? ""; i += 1; + } else { + bodyTokens.push(args[i] ?? ""); } } + const message = bodyTokens.join(" ").trim(); + if (!from || !message) { + fail(USAGE); + } ok( await client.call("teams.send", { team, from, to: member, body: message }), ); diff --git a/tests/cli/team.test.ts b/tests/cli/team.test.ts index 77c63c1e..a90361a1 100644 --- a/tests/cli/team.test.ts +++ b/tests/cli/team.test.ts @@ -103,7 +103,19 @@ function handle( if (!reg) { return { status: "error", message: `team not registered: ${teamName}` }; } + // Mirror kernel contract (fusion-harness team_runtime.send): + // sender AND recipient must be declared members. + const members = ( + (reg.definition.members as Array<{ name: string }> | undefined) ?? [] + ).map((m) => m.name); + const from = String(params.from ?? ""); const to = String(params.to ?? ""); + if (!members.includes(from)) { + return { status: "error", message: `unknown member: ${from}` }; + } + if (!members.includes(to)) { + return { status: "error", message: `unknown member: ${to}` }; + } if (!reg.inboxes[to]) { reg.inboxes[to] = []; } @@ -300,7 +312,14 @@ describe("team CLI", () => { test("send delivers to member mailbox", async () => { const { out, code } = await capture(() => - runMain(["send", "pair", "worker-a", "please start with task-1"]), + runMain([ + "send", + "pair", + "worker-a", + "please start with task-1", + "--from", + "worker-b", + ]), ); expect(code).toBe(0); expect(JSON.parse(out).delivered).toBeTrue(); @@ -310,6 +329,32 @@ describe("team CLI", () => { expect(inbox.at(-1)?.body).toBe("please start with task-1"); }); + test("send without --from fails (kernel rejects undeclared senders)", async () => { + const { out, code } = await capture(() => + runMain(["send", "pair", "worker-a", "no sender given"]), + ); + expect(code).toBe(1); + expect(out).toContain("--from"); + }); + + test("send --from does not leak the flag into the message body", async () => { + const { out, code } = await capture(() => + runMain([ + "send", + "pair", + "worker-a", + "trailing flag", + "--from", + "worker-b", + ]), + ); + expect(code).toBe(0); + const inbox = registry.get("pair")?.inboxes["worker-a"] as Array<{ + body: string; + }>; + expect(inbox.at(-1)?.body).toBe("trailing flag"); + }); + test("status of unknown team fails with server message", async () => { const { out, code } = await capture(() => runMain(["status", "ghost"])); expect(code).toBe(1);