From 9f658b87bea90ef83d625e1f04a01410caa9e885 Mon Sep 17 00:00:00 2001 From: isihussain <35667459+isihussain@users.noreply.github.com> Date: Sat, 14 Nov 2026 11:07:47 +0300 Subject: [PATCH] fix(pulse): let configured kanban columns take precedence over legacy aliases (#2796) When a user adds a column to KANBAN_COLUMNS that matches a status remapped by LEGACY_STATUS_ALIASES (e.g. "Ready" where "ready" maps to "Queued"), deriveColumn previously applied the alias first, placing all Status:ready items into Queued and leaving Ready empty. Update deriveColumn to look for a configured column matching the raw status first, falling back to LEGACY_STATUS_ALIASES only when no configured column matches. Export deriveColumn and add work.columns.test.ts covering configured and fallback scenarios. Closes #2796 Signed-off-by: isihussain --- .../LIFEOS/PULSE/modules/work.columns.test.ts | 21 +++++++++++++++++++ LifeOS/install/LIFEOS/PULSE/modules/work.ts | 5 ++--- 2 files changed, 23 insertions(+), 3 deletions(-) create mode 100644 LifeOS/install/LIFEOS/PULSE/modules/work.columns.test.ts diff --git a/LifeOS/install/LIFEOS/PULSE/modules/work.columns.test.ts b/LifeOS/install/LIFEOS/PULSE/modules/work.columns.test.ts new file mode 100644 index 0000000000..e7317b6f45 --- /dev/null +++ b/LifeOS/install/LIFEOS/PULSE/modules/work.columns.test.ts @@ -0,0 +1,21 @@ +/** + * Verifies that deriveColumn checks configured KANBAN_COLUMNS before applying + * LEGACY_STATUS_ALIASES, allowing custom columns matching raw statuses (e.g. Ready). + * + * Issue #2796 + */ +import { describe, expect, test } from "bun:test"; +import { deriveColumn } from "./work.ts"; + +const columnsWithReady = ["Triage", "Ready", "Queued", "Blocked", "In-Progress", "In-Review", "Complete"]; +const defaultColumns = ["Queued", "Blocked", "In-Progress", "In-Review", "Complete"]; + +describe("deriveColumn", () => { + test("a configured column matching raw status takes precedence over legacy alias", () => { + expect(deriveColumn({ labels: ["Status:ready"], state: "OPEN" }, columnsWithReady)).toBe("Ready"); + }); + + test("legacy aliases still apply when no configured column matches", () => { + expect(deriveColumn({ labels: ["Status:ready"], state: "OPEN" }, defaultColumns)).toBe("Queued"); + }); +}); \ No newline at end of file diff --git a/LifeOS/install/LIFEOS/PULSE/modules/work.ts b/LifeOS/install/LIFEOS/PULSE/modules/work.ts index 566940421a..e961ecb4c9 100644 --- a/LifeOS/install/LIFEOS/PULSE/modules/work.ts +++ b/LifeOS/install/LIFEOS/PULSE/modules/work.ts @@ -123,7 +123,7 @@ function issueSource(labels: string[]): "lifeos-sync" | "auto-native" | "auto-sw return "manual"; } -function deriveColumn(issue: { labels: string[]; state: string }, columns: string[]): string { +export function deriveColumn(issue: { labels: string[]; state: string }, columns: string[]): string { if (issue.state === "CLOSED") { return columns.includes("Complete") ? "Complete" @@ -140,8 +140,7 @@ function deriveColumn(issue: { labels: string[]; state: string }, columns: strin if (label.startsWith("Status:")) { const raw = label.slice("Status:".length).trim().toLowerCase(); const aliased = LEGACY_STATUS_ALIASES[raw]; - const target = aliased ?? raw; - const hit = columns.find((c) => c.toLowerCase() === target.toLowerCase()); + const hit = columns.find((c) => c.toLowerCase() === raw) ?? (aliased ? columns.find((c) => c.toLowerCase() === aliased.toLowerCase()) : undefined); if (hit) return hit; } }