Skip to content

Commit de536db

Browse files
denikIsaac
andauthored
acc: drop no-op rm in apps/missing-service-principal (#7545)
## Changes Follow-up to [#7533](#7533), addressing review feedback: remove `rm -f out.requests.txt` from the `bundle/resources/apps/missing-service-principal` script. The harness records requests to `$OUT_REQUESTS` in a separate output dir, so the line did nothing. The golden output is unchanged: the first `print_requests.py` already listed the create request. The hint text from #7533 stays as is ("wait for the deletion to finish"). Right after `databricks apps delete`, the app is still returned in DELETING, and `bundle plan` plans an update, not a create. `IsGone` is only checked for resources being deleted. So a redeploy run before the deletion finishes does not recreate the app. Details are in the review thread on #7533. ## Tests `go test ./acceptance -run TestAccept/bundle/resources/apps/missing-service-principal` passes locally with no output change. _Written by an AI agent (harness_auto, opus5.5, isaac_claude)._ This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
1 parent 1f483d0 commit de536db

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

  • acceptance/bundle/resources/apps/missing-service-principal

‎acceptance/bundle/resources/apps/missing-service-principal/script‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
trace $CLI bundle deploy
2-
rm -f out.requests.txt
32

43
title "Update fails: the error explains how to recover"
54
trace update_file.py databricks.yml my_app_description MY_APP_DESCRIPTION

0 commit comments

Comments
 (0)