From 3431b4faadb40d71433f40f8486f9f65a5f00cec Mon Sep 17 00:00:00 2001 From: Pieter Noordhuis Date: Tue, 2 Jun 2026 14:40:50 +0200 Subject: [PATCH 1/2] Add missing out.test.toml for designer_notebook acceptance test PR #5370 added the designer_notebook test directory but omitted the generated out.test.toml. The acceptance runner writes this file as a side effect of test discovery and explicitly excludes it from output comparison, so a missing copy never fails a test. Regenerated here. Co-authored-by: Isaac --- acceptance/bundle/paths/designer_notebook/out.test.toml | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 acceptance/bundle/paths/designer_notebook/out.test.toml diff --git a/acceptance/bundle/paths/designer_notebook/out.test.toml b/acceptance/bundle/paths/designer_notebook/out.test.toml new file mode 100644 index 00000000000..f784a183258 --- /dev/null +++ b/acceptance/bundle/paths/designer_notebook/out.test.toml @@ -0,0 +1,3 @@ +Local = true +Cloud = false +EnvMatrix.DATABRICKS_BUNDLE_ENGINE = ["terraform", "direct"] From fbbee163da4f3a9fea7265d1af4692083ac7a91e Mon Sep 17 00:00:00 2001 From: Pieter Noordhuis Date: Tue, 2 Jun 2026 14:44:42 +0200 Subject: [PATCH 2/2] ci: catch new untracked files after running tests The test job already ran 'git diff --exit-code' after the suite, but a plain 'git diff' ignores untracked files. That is how a missing out.test.toml slipped through CI. Register untracked files with intent-to-add first so new files are reported too; .gitignore'd test artifacts are unaffected. Co-authored-by: Isaac --- .github/workflows/push.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml index 479cc6f3b78..0bab4ba3d76 100644 --- a/.github/workflows/push.yml +++ b/.github/workflows/push.yml @@ -152,10 +152,15 @@ jobs: if-no-files-found: warn retention-days: 7 - - name: Check out.test.toml files are up to date + - name: Check no files changed or appeared after running tests run: | + # Register untracked files with intent-to-add so `git diff` reports them + # too; a plain `git diff` ignores new files, which is how a missing + # out.test.toml previously slipped through. Ignored test artifacts are + # unaffected because intent-to-add respects .gitignore. + git add --intent-to-add . if ! git diff --exit-code; then - echo "ERROR: detected changed files in the repository; Most likely you have out.test.toml files that are out of date. Run 'go test ./acceptance -run \"^TestAccept$\" -only-out-test-toml' to update." + echo "ERROR: detected changed or new files in the repository; Most likely you have out.test.toml files that are out of date. Run 'go test ./acceptance -run \"^TestAccept$\" -only-out-test-toml' to update." exit 1 fi