From 3d20ce59b1676d1b773951cccc02bd80f1b1e235 Mon Sep 17 00:00:00 2001 From: "denis.bilenko" Date: Sun, 15 Nov 2026 09:32:12 +0000 Subject: [PATCH 1/4] Add acceptance test for offline labs install without install hook Records current behavior: the CLI panics when a non-string SDK config attribute (DATABRICKS_DEBUG_HEADERS=true) is set in the environment. Co-authored-by: Isaac --- .../out.test.toml | 1 + .../output.txt | 16 ++++++++++++++++ .../install-offline-no-install-hook/script | 19 +++++++++++++++++++ 3 files changed, 36 insertions(+) create mode 100644 acceptance/labs/install-offline-no-install-hook/out.test.toml create mode 100644 acceptance/labs/install-offline-no-install-hook/output.txt create mode 100644 acceptance/labs/install-offline-no-install-hook/script diff --git a/acceptance/labs/install-offline-no-install-hook/out.test.toml b/acceptance/labs/install-offline-no-install-hook/out.test.toml new file mode 100644 index 00000000000..18b1a88417e --- /dev/null +++ b/acceptance/labs/install-offline-no-install-hook/out.test.toml @@ -0,0 +1 @@ +Cloud = false diff --git a/acceptance/labs/install-offline-no-install-hook/output.txt b/acceptance/labs/install-offline-no-install-hook/output.txt new file mode 100644 index 00000000000..6d41886d158 --- /dev/null +++ b/acceptance/labs/install-offline-no-install-hook/output.txt @@ -0,0 +1,16 @@ + +>>> [CLI] labs install foo --offline +The Databricks CLI unexpectedly had a fatal error. +Please report this issue to Databricks in the form of a GitHub issue at: +https://github.com/databricks/cli + +CLI Version: [CLI_VERSION] + +Panic Payload: interface conversion: interface {} is string, not bool + +Stack Trace: +Exit code: 1 + +>>> find home/.databricks/labs/foo -type f +home/.databricks/labs/foo/cache/databrickslabs-foo-releases.json +home/.databricks/labs/foo/lib/labs.yml diff --git a/acceptance/labs/install-offline-no-install-hook/script b/acceptance/labs/install-offline-no-install-hook/script new file mode 100644 index 00000000000..7e261896cc1 --- /dev/null +++ b/acceptance/labs/install-offline-no-install-hook/script @@ -0,0 +1,19 @@ +# Offline install of a project whose labs.yml has no "install:" section, +# with a non-string SDK config attribute set via the environment. +export DATABRICKS_DEBUG_HEADERS=true + +sethome ./home +LABS=home/.databricks/labs/foo +mkdir -p $LABS/lib $LABS/cache +cat > $LABS/lib/labs.yml <<'YML' +name: foo +description: project without an install hook +YML +echo '{"data":[{"tag_name":"v0.1.0"}]}' > $LABS/cache/databrickslabs-foo-releases.json + +# The stack trace (if any) is cut off because it depends on the local Go setup. +errcode trace $CLI labs install foo --offline 2>&1 | sed '/^goroutine /,/^$/d' + +trace find $LABS -type f | sort + +rm -rf home From 0b83bf0b847c5bbec38c14c7e0aa6b6789e95a87 Mon Sep 17 00:00:00 2001 From: "denis.bilenko" Date: Sun, 15 Nov 2026 09:34:01 +0000 Subject: [PATCH 2/4] Fix labs panic on non-string SDK env vars The cli-env config loader passed raw env strings to ConfigAttribute.Set, which panics for bool/int attributes such as DATABRICKS_DEBUG_HEADERS or DATABRICKS_RATE_LIMIT. Use SetS, which parses the value, and stop at the first set env var like the SDK's own loader does. Co-authored-by: Isaac --- .../cli/labs-env-non-string-attributes.md | 1 + .../output.txt | 2 +- libs/env/loader.go | 7 +++++-- libs/env/loader_test.go | 19 +++++++++++++++++++ 4 files changed, 26 insertions(+), 3 deletions(-) create mode 100644 .nextchanges/cli/labs-env-non-string-attributes.md diff --git a/.nextchanges/cli/labs-env-non-string-attributes.md b/.nextchanges/cli/labs-env-non-string-attributes.md new file mode 100644 index 00000000000..0ace15b1844 --- /dev/null +++ b/.nextchanges/cli/labs-env-non-string-attributes.md @@ -0,0 +1 @@ +* Fix a panic in `databricks labs` commands when a non-string SDK setting such as `DATABRICKS_DEBUG_HEADERS` or `DATABRICKS_RATE_LIMIT` is set in the environment. diff --git a/acceptance/labs/install-offline-no-install-hook/output.txt b/acceptance/labs/install-offline-no-install-hook/output.txt index 6d41886d158..710e3346d08 100644 --- a/acceptance/labs/install-offline-no-install-hook/output.txt +++ b/acceptance/labs/install-offline-no-install-hook/output.txt @@ -6,7 +6,7 @@ https://github.com/databricks/cli CLI Version: [CLI_VERSION] -Panic Payload: interface conversion: interface {} is string, not bool +Panic Payload: runtime error: invalid memory address or nil pointer dereference Stack Trace: Exit code: 1 diff --git a/libs/env/loader.go b/libs/env/loader.go index 74c54cee8fa..7da41b4c95b 100644 --- a/libs/env/loader.go +++ b/libs/env/loader.go @@ -2,6 +2,7 @@ package env import ( "context" + "fmt" "github.com/databricks/databricks-sdk-go/config" ) @@ -43,9 +44,11 @@ func (le *configLoader) Configure(cfg *config.Config) error { if v == "" { continue } - if err := a.Set(cfg, v); err != nil { - return err + // SetS parses the string for non-string attributes; Set would panic. + if err := a.SetS(cfg, v); err != nil { + return fmt.Errorf("%s: %w", k, err) } + break } } return nil diff --git a/libs/env/loader_test.go b/libs/env/loader_test.go index 2c2faa57146..621f6bb18c2 100644 --- a/libs/env/loader_test.go +++ b/libs/env/loader_test.go @@ -24,3 +24,22 @@ func TestLoader(t *testing.T) { assert.Equal(t, "abc", cfg.Profile) assert.Equal(t, "cli-env", loader.Name()) } + +func TestLoaderParsesNonStringAttributes(t *testing.T) { + ctx := t.Context() + ctx = env.Set(ctx, "DATABRICKS_DEBUG_HEADERS", "true") + ctx = env.Set(ctx, "DATABRICKS_RATE_LIMIT", "42") + + cfg := &config.Config{} + err := env.NewConfigLoader(ctx).Configure(cfg) + assert.NoError(t, err) + + assert.True(t, cfg.DebugHeaders) + assert.Equal(t, 42, cfg.RateLimitPerSecond) +} + +func TestLoaderReturnsErrorForInvalidValue(t *testing.T) { + ctx := env.Set(t.Context(), "DATABRICKS_RATE_LIMIT", "fast") + err := env.NewConfigLoader(ctx).Configure(&config.Config{}) + assert.ErrorContains(t, err, "DATABRICKS_RATE_LIMIT") +} From b96767a77d27ef52937c51177c5b7da7755593db Mon Sep 17 00:00:00 2001 From: "denis.bilenko" Date: Sun, 15 Nov 2026 09:35:11 +0000 Subject: [PATCH 3/4] Fix labs install panic when labs.yml has no install section installer.login, Install and setupPythonVirtualEnvironment dereferenced i.Installer, which is nil when labs.yml has no install hook. Use the project's meta entrypoint (which is what Installer.Entrypoint is set to) and guard the Extras lookup. Co-authored-by: Isaac --- .../cli/labs-install-without-install-hook.md | 1 + .../labs/install-offline-no-install-hook/output.txt | 12 ++---------- cmd/labs/project/installer.go | 9 +++++---- 3 files changed, 8 insertions(+), 14 deletions(-) create mode 100644 .nextchanges/cli/labs-install-without-install-hook.md diff --git a/.nextchanges/cli/labs-install-without-install-hook.md b/.nextchanges/cli/labs-install-without-install-hook.md new file mode 100644 index 00000000000..e06343135db --- /dev/null +++ b/.nextchanges/cli/labs-install-without-install-hook.md @@ -0,0 +1 @@ +* Fix a panic in `databricks labs install` for projects whose `labs.yml` has no `install` section. diff --git a/acceptance/labs/install-offline-no-install-hook/output.txt b/acceptance/labs/install-offline-no-install-hook/output.txt index 710e3346d08..c215938d175 100644 --- a/acceptance/labs/install-offline-no-install-hook/output.txt +++ b/acceptance/labs/install-offline-no-install-hook/output.txt @@ -1,16 +1,8 @@ >>> [CLI] labs install foo --offline -The Databricks CLI unexpectedly had a fatal error. -Please report this issue to Databricks in the form of a GitHub issue at: -https://github.com/databricks/cli - -CLI Version: [CLI_VERSION] - -Panic Payload: runtime error: invalid memory address or nil pointer dereference - -Stack Trace: -Exit code: 1 >>> find home/.databricks/labs/foo -type f home/.databricks/labs/foo/cache/databrickslabs-foo-releases.json +home/.databricks/labs/foo/config/login.json home/.databricks/labs/foo/lib/labs.yml +home/.databricks/labs/foo/state/version.json diff --git a/cmd/labs/project/installer.go b/cmd/labs/project/installer.go index 32a74b6808f..8cd5e5cdac5 100644 --- a/cmd/labs/project/installer.go +++ b/cmd/labs/project/installer.go @@ -92,7 +92,7 @@ func (i *installer) Install(ctx context.Context) error { } w, err := i.login(ctx) if err != nil && errors.Is(err, profile.ErrNoConfiguration) { - cfg, err := i.Installer.envAwareConfig(ctx) + cfg, err := i.metaEntrypoint(ctx).envAwareConfig(ctx) if err != nil { return err } @@ -171,7 +171,7 @@ func (i *installer) recordVersion(ctx context.Context) error { func (i *installer) login(ctx context.Context) (*databricks.WorkspaceClient, error) { cfg, err := i.metaEntrypoint(ctx).validLogin(i.cmd) if errors.Is(err, ErrNoLoginConfig) { - cfg, err = i.Installer.envAwareConfig(ctx) + cfg, err = i.metaEntrypoint(ctx).envAwareConfig(ctx) if err != nil { return nil, err } @@ -181,7 +181,8 @@ func (i *installer) login(ctx context.Context) (*databricks.WorkspaceClient, err if !i.HasAccountLevelCommands() && cfg.ConfigType() == config.AccountConfig { return nil, errors.New("got account-level client, but no account-level commands") } - lc := &loginConfig{Entrypoint: i.Installer.Entrypoint} + // labs.yml may have no install hook, so i.Installer can be nil. + lc := &loginConfig{Entrypoint: i.metaEntrypoint(ctx)} w, err := lc.askWorkspace(ctx, cfg) if err != nil { return nil, fmt.Errorf("ask for workspace: %w", err) @@ -263,7 +264,7 @@ func (i *installer) setupPythonVirtualEnvironment(ctx context.Context, w *databr } } sp.Update("Installing Python library dependencies") - if i.Installer.Extras != "" { + if i.Installer != nil && i.Installer.Extras != "" { // install main and optional dependencies return i.installPythonDependencies(ctx, fmt.Sprintf(".[%s]", i.Installer.Extras)) } From 0e9de1f2fdad43dca145235032506e08c164b29f Mon Sep 17 00:00:00 2001 From: "denis.bilenko" Date: Mon, 16 Nov 2026 10:29:53 +0000 Subject: [PATCH 4/4] Add PR link to changelog fragment Co-authored-by: Isaac --- .nextchanges/cli/labs-env-non-string-attributes.md | 2 +- .nextchanges/cli/labs-install-without-install-hook.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.nextchanges/cli/labs-env-non-string-attributes.md b/.nextchanges/cli/labs-env-non-string-attributes.md index 0ace15b1844..dceaa9b4c26 100644 --- a/.nextchanges/cli/labs-env-non-string-attributes.md +++ b/.nextchanges/cli/labs-env-non-string-attributes.md @@ -1 +1 @@ -* Fix a panic in `databricks labs` commands when a non-string SDK setting such as `DATABRICKS_DEBUG_HEADERS` or `DATABRICKS_RATE_LIMIT` is set in the environment. +* Fix a panic in `databricks labs` commands when a non-string SDK setting such as `DATABRICKS_DEBUG_HEADERS` or `DATABRICKS_RATE_LIMIT` is set in the environment. ([#7673](https://github.com/databricks/cli/pull/7673)) diff --git a/.nextchanges/cli/labs-install-without-install-hook.md b/.nextchanges/cli/labs-install-without-install-hook.md index e06343135db..44113007422 100644 --- a/.nextchanges/cli/labs-install-without-install-hook.md +++ b/.nextchanges/cli/labs-install-without-install-hook.md @@ -1 +1 @@ -* Fix a panic in `databricks labs install` for projects whose `labs.yml` has no `install` section. +* Fix a panic in `databricks labs install` for projects whose `labs.yml` has no `install` section. ([#7673](https://github.com/databricks/cli/pull/7673))