From 7750877798b992ff02620e5b1389c091e70199ac Mon Sep 17 00:00:00 2001 From: "denis.bilenko" Date: Wed, 18 Nov 2026 05:29:32 +0000 Subject: [PATCH 1/2] acc: suppress DMS history warnings caused by transport errors Deployment history recording is best effort. A dropped HTTP/2 stream, an unexpected EOF or the drain deadline only produces a warning, but that warning fails the DMS=true variant because it shares goldens with the plain run. Suppress only those transport-caused warnings. Errors the service returns are still compared. cloud: TestAccept/bundle/config-remote-sync/cli_defaults/DMS=true TestAccept/bundle/resources/dashboards/delete-trashed-out-of-band/DMS=true TestAccept/bundle/resources/secrets/basic/DMS=true Co-authored-by: Isaac --- acceptance/bundle/test.toml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/acceptance/bundle/test.toml b/acceptance/bundle/test.toml index 20200b31ab9..4274485005d 100644 --- a/acceptance/bundle/test.toml +++ b/acceptance/bundle/test.toml @@ -12,6 +12,13 @@ Ignore = ["databricks.yml"] # The lowest Python version we support. Alternative to "uv run --python 3.10" Env.UV_PYTHON = "3.10" +# Recording history is best effort: with recording on, the CLI only warns when a call to the +# service fails. The plain run makes no such calls, and the goldens are shared, so a warning caused +# by a dropped connection would fail the DMS=true run. Only transport-level causes are suppressed +# (the lines go to the test log). An error the service returns is still compared, so a request +# the service rejects still fails the test. +SuppressLines.warn_dms_transport = '^Warn: (Failed to (record|complete) deployment history|Could not (enable|record|read) deployment history)\b.*(stream error: stream ID \S+; INTERNAL_ERROR; received from peer|unexpected EOF|context deadline exceeded)$' + # The link a recorded deploy prints, dropped so a test asserts the same output whether or # not recording is on. The URL itself is covered by workspaceurls.TestDeploymentURL, and # the calls behind it by the bundle/dms tests. From 47a734de4c0e0119dd392f3cd45afe8b5b7a9b05 Mon Sep 17 00:00:00 2001 From: "denis.bilenko" Date: Wed, 18 Nov 2026 07:17:37 +0000 Subject: [PATCH 2/2] acc: cover delete warning and pin DMS transport suppression Add "Could not delete deployment history" to the suppressed warnings: deleteDeployment retries only IsTransient, so a stream reset during destroy still produced the warning. Name the drain budget as the source of "context deadline exceeded" in the comment. Add bundle/dms/suppress-transport-warnings, which echoes lines the pattern must suppress and lines it must keep. cloud: TestAccept/bundle/config-remote-sync/cli_defaults/DMS=true TestAccept/bundle/resources/secrets/basic/DMS=true Co-authored-by: Isaac --- .../dms/suppress-transport-warnings/out.test.toml | 2 ++ .../dms/suppress-transport-warnings/output.txt | 4 ++++ .../bundle/dms/suppress-transport-warnings/script | 14 ++++++++++++++ .../dms/suppress-transport-warnings/test.toml | 3 +++ acceptance/bundle/test.toml | 12 +++++++----- 5 files changed, 30 insertions(+), 5 deletions(-) create mode 100644 acceptance/bundle/dms/suppress-transport-warnings/out.test.toml create mode 100644 acceptance/bundle/dms/suppress-transport-warnings/output.txt create mode 100644 acceptance/bundle/dms/suppress-transport-warnings/script create mode 100644 acceptance/bundle/dms/suppress-transport-warnings/test.toml diff --git a/acceptance/bundle/dms/suppress-transport-warnings/out.test.toml b/acceptance/bundle/dms/suppress-transport-warnings/out.test.toml new file mode 100644 index 00000000000..88e6fbd847c --- /dev/null +++ b/acceptance/bundle/dms/suppress-transport-warnings/out.test.toml @@ -0,0 +1,2 @@ +Cloud = false +EnvMatrix.DMS = ["true"] diff --git a/acceptance/bundle/dms/suppress-transport-warnings/output.txt b/acceptance/bundle/dms/suppress-transport-warnings/output.txt new file mode 100644 index 00000000000..df85288efc3 --- /dev/null +++ b/acceptance/bundle/dms/suppress-transport-warnings/output.txt @@ -0,0 +1,4 @@ +Warn: Could not enable deployment history for this deploy: failed to create deployment: +Warn: Could not enable deployment history for this deploy: failed to create deployment version: operations.resource_key must have a known resource type +Warn: Failed to complete deployment history version: Internal error +Error: cannot create resources.secrets.foo: response body: stream error: stream ID 73; INTERNAL_ERROR; received from peer diff --git a/acceptance/bundle/dms/suppress-transport-warnings/script b/acceptance/bundle/dms/suppress-transport-warnings/script new file mode 100644 index 00000000000..9aeed2c3017 --- /dev/null +++ b/acceptance/bundle/dms/suppress-transport-warnings/script @@ -0,0 +1,14 @@ +# Suppressed: best-effort history warnings caused by a dropped connection or the drain budget. +echo "Warn: Failed to record deployment history: recording operation for resources.pipelines.foo: response body: stream error: stream ID 51; INTERNAL_ERROR; received from peer" +echo "Warn: Failed to complete deployment history version: response body: stream error: stream ID 9429; INTERNAL_ERROR; received from peer" +echo "Warn: Could not enable deployment history for this deploy: failed to create deployment: response body: stream error: stream ID 43; INTERNAL_ERROR; received from peer" +echo "Warn: Could not record deployment history for this destroy: failed to create deployment version: unexpected EOF" +echo "Warn: Could not read deployment history: response body: stream error: stream ID 13; INTERNAL_ERROR; received from peer" +echo "Warn: Could not delete deployment history: response body: stream error: stream ID 7; INTERNAL_ERROR; received from peer" +echo "Warn: Failed to record deployment history: context deadline exceeded" + +# Kept: errors the service returns, and transport errors outside deployment history. +echo "Warn: Could not enable deployment history for this deploy: failed to create deployment: " +echo "Warn: Could not enable deployment history for this deploy: failed to create deployment version: operations.resource_key must have a known resource type" +echo "Warn: Failed to complete deployment history version: Internal error" +echo "Error: cannot create resources.secrets.foo: response body: stream error: stream ID 73; INTERNAL_ERROR; received from peer" diff --git a/acceptance/bundle/dms/suppress-transport-warnings/test.toml b/acceptance/bundle/dms/suppress-transport-warnings/test.toml new file mode 100644 index 00000000000..8c5ad2971d8 --- /dev/null +++ b/acceptance/bundle/dms/suppress-transport-warnings/test.toml @@ -0,0 +1,3 @@ +# Only echoes lines: no workspace, no requests. +Cloud = false +RecordRequests = false diff --git a/acceptance/bundle/test.toml b/acceptance/bundle/test.toml index 4274485005d..edf7958b308 100644 --- a/acceptance/bundle/test.toml +++ b/acceptance/bundle/test.toml @@ -13,11 +13,13 @@ Ignore = ["databricks.yml"] Env.UV_PYTHON = "3.10" # Recording history is best effort: with recording on, the CLI only warns when a call to the -# service fails. The plain run makes no such calls, and the goldens are shared, so a warning caused -# by a dropped connection would fail the DMS=true run. Only transport-level causes are suppressed -# (the lines go to the test log). An error the service returns is still compared, so a request -# the service rejects still fails the test. -SuppressLines.warn_dms_transport = '^Warn: (Failed to (record|complete) deployment history|Could not (enable|record|read) deployment history)\b.*(stream error: stream ID \S+; INTERNAL_ERROR; received from peer|unexpected EOF|context deadline exceeded)$' +# service fails. The plain run makes no such calls, and the goldens are shared, so such a warning +# would fail the DMS=true run. Suppressed (moved to the test log) only when the cause is a +# dropped connection (HTTP/2 stream reset, unexpected EOF) or the history drain budget running +# out ("context deadline exceeded" from OperationBuffer.Drain, which a slow service also hits). +# An error the service returns is still compared, so a request it rejects still fails the test. +# Pinned by bundle/dms/suppress-transport-warnings. +SuppressLines.warn_dms_transport = '^Warn: (Failed to (record|complete) deployment history|Could not (enable|record|read|delete) deployment history)\b.*(stream error: stream ID \S+; INTERNAL_ERROR; received from peer|unexpected EOF|context deadline exceeded)$' # The link a recorded deploy prints, dropped so a test asserts the same output whether or # not recording is on. The URL itself is covered by workspaceurls.TestDeploymentURL, and